fix(iOS): reset to first frame on app resume bug #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsocj
commented
Jan 31, 2023
|
|
||
| func applyProperties() { | ||
| func applyColorProperties() { |
There was a problem hiding this comment.
Only apply color properties here. Setting animationSpeed or loopMode resets the animation
alfonsocj
commented
Jan 31, 2023
|
@matinzd I think it's ready for review. |
matinzd
changed the title
matinzd
approved these changes
Jan 31, 2023
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where the animation resets to its first frame when going to background and resume.
Issue: #825
Why this problem occured?
When going to background,
traitCollectionDidChangemethod runs which callsapplyProperties(). This changes the animation's current progressanimationView.currentProgress = progressandprogresscomes from props. If not defined it defaults to 0 (first frame).Additionally, setting
backgroundBehavior = .pauseAndRestorehas a weird behavior. When the animation ends and the app goes to background, it sets the animation to the first frame. Forcing thecurrentProgressto the last frame when the animation ends works fine to mitigate the issue.Before
Screen.Recording.2023-01-31.at.10.30.04.AM.mov
After
Jan-31-2023.12-10-05-2.mov