Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to lottie-ios 3.0.x #486

Merged
merged 4 commits into from
Jun 5, 2019

Conversation

prateekkohli1989
Copy link

@prateekkohli1989 prateekkohli1989 commented May 22, 2019

Summary

  • React Native Lottie iOS upgrade to use Lottie-iOS 3.x

  • Rewrite native modules in swift to use latest methods and properties of lottie-ios

It shouldn't impact any library.

Test Plan

Run the existing sample app. Here is the attached gif
lottie

What's required for testing (prerequisites)?

  1. npm install on the root directory
  2. Clean the xcode derive data and run pod install inside the example folder
  3. xcode 10.1

What are the steps to reproduce (after prerequisites)?

  1. Run the sample app.

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@prateekkohli1989 prateekkohli1989 changed the title React native lottie upgrade Upgrade to lottie-ios 3.0.x May 22, 2019
@mariozig
Copy link

Hi @emilioicai are you the right assignee for this PR? thanks!

Copy link

@mariozig mariozig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We have been running @prateekkohli1989 's fork internally and working fine!

@emilioicai
Copy link
Member

Great! Sure, I will review and merge asap. This was long awaited :)

@mariozig
Copy link

mariozig commented Jun 4, 2019

Awesome, thank you @emilioicai!

@emilioicai emilioicai self-assigned this Jun 5, 2019
@emilioicai emilioicai merged commit 7f86d9d into lottie-react-native:master Jun 5, 2019
@radex radex mentioned this pull request Jun 28, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants