-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support filter media items between dates #140
Support filter media items between dates #140
Conversation
looks good, thanks! |
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@bartolkaruza I'm using 1.4.1 also tried 1.4.0, Without time filter system fetch all the photos from the camerarole that I have added few minutes/hours back, but unable to get any photo if I add 'fromTime' and 'toTime'. Can you please confirm if this issue is fixed in this PR?
|
@imranmirza-nxb I tried your code above, works well for me on both android and ios
|
@r0b0t3d in my case getPhotos without time filter returns me 'timestamp = 0' not sure why, this might be an issue, is there anything required to save timestamp while storing in camerarole ?
|
I haven't got the problem with |
Thanks for quick response. I'm testing so far over Android Simulator. My getPhotos returns me following object with timestamp=0: Can you please confirm two things for your case:
|
@imranmirza-nxb just tried with emulator (android 10), got the same problem as yours. It seems something went wrong with emulator or android 10 (not sure about it). |
Yes, On real device this is working fine, the module has issue with emulator only. |
Summary
This PR is a replacement of #120 that I closed accidentally. So I am going to copy the description below.
Add
fromTime
andtoTime
togetPhotos
to get media items in betweenTest Plan
Manual test on my device
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
CHANGELOG.md
example/App.js
)