Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused import that breaks the build for RN >= 0.60 #150

Merged
merged 1 commit into from
Mar 26, 2020
Merged

remove unused import that breaks the build for RN >= 0.60 #150

merged 1 commit into from
Mar 26, 2020

Conversation

justinwh
Copy link
Contributor

Summary

Removes an unused import that caused the build to fail on RN >= 0.60

Fixes #147

Test Plan

N/A

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@Danny-A
Copy link

Danny-A commented Mar 17, 2020

Can we help to speed up the process of merging this?

@bartolkaruza bartolkaruza merged commit 334ab0e into react-native-cameraroll:master Mar 26, 2020
bartolkaruza pushed a commit that referenced this pull request Mar 26, 2020
@semantic-release-bot
chore(release): 1.5.0 [skip ci]
b4d1576 
# [1.5.0](v1.4.1...v1.5.0) (2020-03-26)

### Bug Fixes

* remove unused import that breaks the build for RN >= 0.60 ([#150](#150)) ([334ab0e](334ab0e))
* Update deprecated functions ([#149](#149)) ([3e38ab1](3e38ab1))

### Features

* get album list ([#139](#139)) ([fc1855e](fc1855e))
@bartolkaruza
Copy link
Collaborator

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to build with RN 0.64 'React/RCTImageLoaderProtocol.h' file not found
3 participants
@justinwh @Danny-A @bartolkaruza