fix: deprecate saveToCameraRoll #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 11, 2020
`CameraRoll` in React Native core is deprecated [1], and removed in RN v0.61. We are to use `@react-native-community/cameraroll` instead. So, do. Very recently, the `saveToCameraRoll` method was removed in favor of `save` [2]. The first argument is exactly the same; further config is possible in later arguments if we want to. Thankfully, this library has built-in Flow support, so we don't need to make our own libdef. But the types haven't yet been updated to reflect the removal of `saveToCameraRoll`; that should be coming soon [3]. As with several other modules that use native code, mock it in jest/jestSetup.js to avoid numerous errors on running `tools/test jest`. [1]: https://reactnative.dev/docs/0.60/cameraroll [2]: react-native-cameraroll/react-native-cameraroll#183 [3]: react-native-cameraroll/react-native-cameraroll#184
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 11, 2020
`CameraRoll` in React Native core is deprecated [1]. In the upcoming RN v0.60 -> v0.61 upgrade, we see errors that it has in fact been removed from `react-native`. We are to use `@react-native-community/cameraroll` instead. So, do. Very recently, the `saveToCameraRoll` method was removed in favor of `save` [2]. The first argument is exactly the same; further config is possible in later arguments if we want to. Thankfully, this library has built-in Flow support, so we don't need to make our own libdef. But the types haven't yet been updated to reflect the removal of `saveToCameraRoll`; that should be coming soon [3]. As with several other modules that use native code, mock it in jest/jestSetup.js to avoid numerous errors on running `tools/test jest`. [1]: https://reactnative.dev/docs/0.60/cameraroll [2]: react-native-cameraroll/react-native-cameraroll#183 [3]: react-native-cameraroll/react-native-cameraroll#184
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 12, 2020
`CameraRoll` in React Native core is deprecated [1]. In the upcoming RN v0.60 -> v0.61 upgrade, we see errors that it has in fact been removed from `react-native`. We are to use `@react-native-community/cameraroll` instead. So, do. Very recently, the `saveToCameraRoll` method was removed in favor of `save` [2]. The first argument is exactly the same; further config is possible in later arguments if we want to. Thankfully, this library has built-in Flow support, so we don't need to make our own libdef. But the types haven't yet been updated to reflect the removal of `saveToCameraRoll`; that should be coming soon [3]. Also tell our Jest config to use Babel on `node_modules/@react-native-community/cameraroll`, as it's not compiled. [1]: https://reactnative.dev/docs/0.60/cameraroll [2]: react-native-cameraroll/react-native-cameraroll#183 [3]: react-native-cameraroll/react-native-cameraroll#184
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 12, 2020
`CameraRoll` in React Native core is deprecated [1]. In the upcoming RN v0.60 -> v0.61 upgrade, we see errors that it has in fact been removed from `react-native`. We are to use `@react-native-community/cameraroll` instead. So, do. Very recently, the `saveToCameraRoll` method was removed in favor of `save` [2]. The first argument is exactly the same; further config is possible in later arguments if we want to. Thankfully, this library has built-in Flow support, so we don't need to make our own libdef. But the types haven't yet been updated to reflect the removal of `saveToCameraRoll`; that should be coming soon [3]. Also tell our Jest config to use Babel on `node_modules/@react-native-community/cameraroll`, as it's not compiled. [1]: https://reactnative.dev/docs/0.60/cameraroll [2]: react-native-cameraroll/react-native-cameraroll#183 [3]: react-native-cameraroll/react-native-cameraroll#184
gnprice
pushed a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Jun 12, 2020
`CameraRoll` in React Native core is deprecated [1]. In the upcoming RN v0.60 -> v0.61 upgrade, we see errors that it has in fact been removed from `react-native`. We are to use `@react-native-community/cameraroll` instead. So, do. Very recently, the `saveToCameraRoll` method was removed in favor of `save` [2]. The first argument is exactly the same; further config is possible in later arguments if we want to. Thankfully, this library has built-in Flow support, so we don't need to make our own libdef. But the types haven't yet been updated to reflect the removal of `saveToCameraRoll`; that should be coming soon [3]. Also tell our Jest config to use Babel on `node_modules/@react-native-community/cameraroll`, as it's not compiled. [1]: https://reactnative.dev/docs/0.60/cameraroll [2]: react-native-cameraroll/react-native-cameraroll#183 [3]: react-native-cameraroll/react-native-cameraroll#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#182
Compatibility
Checklist
README.mdexample/App.js)