Added imageSize and playableDuration to include param, deletes isStored
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
|
@hsource the other PR is merged, happy to help merging this |
|
Thanks! I rebased the change and retested it, and updated the GIFs in the original post! Take a look. It should be ready for review and submission @bartolkaruza |
hsource
changed the title
include paraminclude param, deletes isStored
bartolkaruza
approved these changes
Jun 20, 2020
android/src/main/java/com/reactnativecommunity/cameraroll/CameraRollModule.java
Show resolved
Hide resolved
|
Thank you for contributing @hsource ! |
bartolkaruza
pushed a commit
that referenced
this pull request
Jun 23, 2020
# [3.0.0](v2.0.0...v3.0.0) (2020-06-23) ### Features * Added imageSize and playableDuration to `include` param, deletes isStored ([#187](#187)) ([ec33d32](ec33d32)) ### BREAKING CHANGES * imageSize and playableDuration are no longer included by default to improve performance
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is another change that is not backwards compatible
I realized that the Android implementation still had poor performance since it looped through individual images to populate
image.width/height(some of the time) andimage.playableDuration(for every video).Excluding
playableDurationin particular improves performance significantly when the user has videos.This change:
includeparams forimage.width,image.height, andimage.playableDurationSide change:
isStoredoutput that's just a boolean always set to true on iOSTest Plan
Added toggles to GetPhotosPerformanceExample.
What's required for testing (prerequisites)?
Just the standard
yarn start:iosandyarn start:androidWhat are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)