Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated react dependency in podspec to enable build in Xcode 12 (for iOS >= 12) #260

Merged
merged 2 commits into from
Jan 16, 2021
Merged

fix: updated react dependency in podspec to enable build in Xcode 12 (for iOS >= 12) #260

merged 2 commits into from
Jan 16, 2021

Conversation

alexisbronchart
Copy link
Contributor

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Dec 2, 2020 •
edited

Just a heads-up 🙂: this would break compatibility with RN v0.59 and earlier because React-Core doesn't exist until facebook/react-native@2321b3fd7, which was released in RN v0.60.

The range for react-native under peerDependencies in package.json currently (as of 4.0.1; link) contains versions that would no longer work; I would recommend narrowing that range so that it excludes them, and announcing this as a breaking change in a major-version release.

@chrisbobbe chrisbobbe mentioned this pull request Dec 2, 2020
Closed
chrisbobbe
chrisbobbe reviewed Dec 3, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@chrisbobbe chrisbobbe mentioned this pull request Jan 11, 2021
Closed
Naturalclar
Naturalclar approved these changes Jan 16, 2021
View reviewed changes
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexisbronchart @chrisbobbe Thanks!

@Naturalclar Naturalclar merged commit 4f16a5a into react-native-cameraroll:master Jan 16, 2021
bartolkaruza pushed a commit that referenced this pull request Jan 27, 2021
@semantic-release-bot
chore(release): 4.0.2 [skip ci]
7fa9b7c 
## [4.0.2](v4.0.1...v4.0.2) (2021-01-27)

### Bug Fixes

* RuntimeException on faulty video files ([#241](#241)) ([a83ad4c](a83ad4c)), closes [#239](#239)
* updated react dependency in podspec to enable build in Xcode 12 (for iOS >= 12) ([#260](#260)) ([4f16a5a](4f16a5a))
@bartolkaruza
Copy link
Collaborator

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbobbe chrisbobbe chrisbobbe left review comments

@Naturalclar Naturalclar Naturalclar approved these changes

@karvulf karvulf karvulf approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexisbronchart @chrisbobbe @bartolkaruza @Naturalclar @karvulf