Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom path for GoogleService-Info.plist #576

Conversation

chaitanya-bhagavan
Copy link

This PR adds feature to have Dev and Production versions of GoogleService-Info.plist

@vonovak
Copy link
Member

vonovak commented Nov 19, 2018

hi @chaitanya0bhagvan thanks for the PR; can you explain the motivation for this? TBH I'd rather see people use the approach outlined here because custom locations of this file seem to give trouble to firebase - would this approach work for you? Alternatively, people can use custom iosClientId config option.

@chaitanya-bhagavan
Copy link
Author

Hi @vonovak I was not aware of this approach of using a build phase, it seems like a better solution. I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants