Updates to build.gradle #2006
Closed
Updates to build.gradle #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes! This is sorely needed. |
|
LGTM @alvelig 🐽 |
|
Here's a better idea. Simply check for gradle properties defined in one's root |
|
@bsmarimon Why don't we step to 27 right away? @christocracy so you advice against upgrading? @rborn sorry, was very busy last week. |
|
I think we'll close that in favor of #2047, don't you mind, @bsmarimon? |
|
@christocracy Yes, I've already seen that and I agree totally |
|
Closing in favour of #2047 @bsmarimon thanks for your PR 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was wondering if it'd be possible to update the sdkVersions and buildToolsVersions used in the android side of the project. In my experience so far, the newer versions of gradle (3.0) require the versions to be at least 26.