Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tileSize props for iOS. #2627

Merged

Conversation

Projects
None yet
2 participants
@fozhao
Copy link
Contributor

commented Dec 14, 2018

Does any other open PR do the same thing?

There are some related open issues talking about tile size. And there is one issue asking for PR of tile size props. So here it is this PR trying to resolve these issue.

What issue is this PR fixing?

Support for tileSize in UrlTile props #2567

How did you test this PR?

On iOS, use the sample code to initialize a map view with URL tile on it. And the tile's size should be other than 256 to trigger the issue that on iOS default tile size (256 * 256) is always used.

Then in your UrlTile component, add a tileSize prop with the expected tile size number and run your app again. Now you should see the tile being correctly rendered according to your tile size prop.

zhaohongyi and others added some commits Dec 14, 2018

zhaohongyi

@christopherdro christopherdro merged commit 5a718a2 into react-native-community:master Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.