Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bundler error when running the Android example #320

Merged
merged 1 commit into from Jun 15, 2019
Merged

fix: bundler error when running the Android example #320

merged 1 commit into from Jun 15, 2019

Conversation

kenyontu
Copy link
Contributor

Overview

When trying to run the current Android example, the bundler throws the following error:

Error: Unable to resolve module `./index` from `/Users/kenyontu/github/react-native-modal/.`: The module `./index` could not be found from `/Users/kenyontu/github/react-native-modal/.`. Indeed, none of these files exist:
  * `/Users/kenyontu/github/react-native-modal/index(.native||.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)`
  * `/Users/kenyontu/github/react-native-modal/index/index(.native||.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)`
    at ModuleResolver.resolveDependency (/Users/kenyontu/github/react-native-modal/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:163:15)
    at ResolutionRequest.resolveDependency (/Users/kenyontu/github/react-native-modal/node_modules/metro/src/node-haste/DependencyGraph/ResolutionRequest.js:52:18)
    at DependencyGraph.resolveDependency (/Users/kenyontu/github/react-native-modal/node_modules/metro/src/node-haste/DependencyGraph.js:273:16)
    at /Users/kenyontu/github/react-native-modal/node_modules/metro/src/lib/transformHelpers.js:261:42
    at Server.<anonymous> (/Users/kenyontu/github/react-native-modal/node_modules/metro/src/Server.js:935:41)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/kenyontu/github/react-native-modal/node_modules/metro/src/Server.js:73:24)
    at _next (/Users/kenyontu/github/react-native-modal/node_modules/metro/src/Server.js:93:9)
::ffff:127.0.0.1 - - [15/Jun/2019:07:05:01 +0000] "GET /index.delta\?platform=android&dev=true&minify=false HTTP/1.1" 500 - "-" "okhttp/3.12.1"

Note: The iOS example works fine.

Test Plan

Steps to check the issue:

  • Clone the master branch
  • Install dependencies with yarn install
  • Run yarn start:android

mmazzarolo
mmazzarolo approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@mmazzarolo mmazzarolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenyontu looks good to me, thank you for the PR!

@mmazzarolo mmazzarolo merged commit 6dc475b into react-native-modal:master Jun 15, 2019
react-native-community-bot pushed a commit that referenced this pull request Jun 15, 2019
@semantic-release-bot
chore(release): 11.0.2 [skip ci]
269370b 
## [11.0.2](v11.0.1...v11.0.2) (2019-06-15)

### Bug Fixes

* bundler error when running android example ([#320](#320)) ([6dc475b](6dc475b))
@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 11.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

happyboy000916 added a commit to happyboy000916/react-native-modal that referenced this pull request May 31, 2023
@happyboy000916
chore(release): 11.0.2 [skip ci]
797114a 
## [11.0.2](react-native-modal/react-native-modal@v11.0.1...v11.0.2) (2019-06-15)

### Bug Fixes

* bundler error when running android example ([#320](react-native-modal/react-native-modal#320)) ([6dc475b](react-native-modal/react-native-modal@6dc475b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmazzarolo mmazzarolo mmazzarolo approved these changes

@ancyrweb ancyrweb Awaiting requested review from ancyrweb

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenyontu @react-native-community-bot @mmazzarolo