feat: Add panResponderThreshold to props (#469) #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 11.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
happyboy000916
added a commit
to happyboy000916/react-native-modal
that referenced
this pull request
May 31, 2023
# [11.9.0](react-native-modal/react-native-modal@v11.8.0...v11.9.0) (2021-04-10) ### Features * Add panResponderThreshold to props ([#469](react-native-modal/react-native-modal#469)) ([#526](react-native-modal/react-native-modal#526)) ([6145c5b](react-native-modal/react-native-modal@6145c5b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A variable in the code is hardcoded when it really should be configurable if the developer wishes.
Test Plan
Fire up a modal and make sure you can still swipe it closed.
Note - all the additional formatting fixes are due to the husky pre-commit hooks (from the master branch) auto-fixing missing semi-colons and indenting when I committed. My understanding is the maintainers want it in there to make sure commits are "pretty". If you guys don't want it, please update the master branch and remove it so developers trying to contribute don't get confused by what's going on. Then I'll refork, make my changes, and re-commit.