Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update README providing React Hooks usage instead Class #431

Merged
merged 2 commits into from May 5, 2020
Merged

Docs: update README providing React Hooks usage instead Class #431

merged 2 commits into from May 5, 2020

Conversation

caiangums
Copy link
Contributor

Overview

First of all, thanks for your awesome project!

The changes were made as a recommendation of the React Community in using React Hooks for writing Components with states without writing them as Classes after the React version 16.8.

It also works in TypeScript but it would be a big change for this project to do all at once, and it is not my intention to change without need or approval.

I'm already using this lib with hooks and it works perfectly, as the hook is used outside the lib itself, but my intention is encouraging new-comers to use hooks instead of Class-based components.

Test Plan

I didn't change any code, just the README.md file, so I'll leave this section empty.

…ss-based Components, as a recommendation of React community
Copy link
Member

@mmazzarolo mmazzarolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmazzarolo mmazzarolo merged commit b346e1e into react-native-modal:master May 5, 2020
@mmazzarolo
Copy link
Member

Thanks so much @caiangums 🎈

@caiangums caiangums deleted the docs/update-readme-using-hooks branch May 5, 2020 23:32
@ancyrweb
Copy link
Member

ancyrweb commented May 6, 2020

Many thanks !

@mmazzarolo
Copy link
Member

🎉 This PR is included in version 11.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants