fix: social should be optional in android

I also added stack traces for debugging, that was how I found it
react-native-share · Aug 14, 2019 · abad39d · abad39d
1 parent 8359e6f
commit abad39d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/android/src/main/java/cl/json/RNShareModule.java b/android/src/main/java/cl/json/RNShareModule.java
@@ -133,12 +133,12 @@ public void open(ReadableMap options, @Nullable Callback failureCallback, @Nulla
             GenericShare share = new GenericShare(this.reactContext);
             share.open(options);
         } catch (ActivityNotFoundException ex) {
-            System.out.println("ERROR");
-            System.out.println(ex.getMessage());
+            System.out.println("ERROR " + ex.getMessage());
+            ex.printStackTrace(System.out);
             TargetChosenReceiver.sendCallback(false, "not_available");
         } catch (Exception e) {
-            System.out.println("ERROR");
-            System.out.println(e.getMessage());
+            System.out.println("ERROR " + e.getMessage());
+            e.printStackTrace(System.out);
             TargetChosenReceiver.sendCallback(false, e.getMessage());
         }
     }
@@ -156,12 +156,12 @@ public void shareSingle(ReadableMap options, @Nullable Callback failureCallback,
                     throw new ActivityNotFoundException("Invalid share activity");
                 }
             } catch (ActivityNotFoundException ex) {
-                System.out.println("ERROR");
-                System.out.println(ex.getMessage());
+                System.out.println("ERROR " + ex.getMessage());
+                ex.printStackTrace(System.out);
                 TargetChosenReceiver.sendCallback(false, ex.getMessage());
             } catch (Exception e) {
-                System.out.println("ERROR");
-                System.out.println(e.getMessage());
+                System.out.println("ERROR " + e.getMessage());
+                e.printStackTrace(System.out);
                 TargetChosenReceiver.sendCallback(false, e.getMessage());
             }
         } else {
@@ -191,8 +191,8 @@ public void isBase64File(String url, @Nullable Callback failureCallback, @Nullab
                 successCallback.invoke(false);
             }
         } catch (Exception e) {
-            System.out.println("ERROR");
-            System.out.println(e.getMessage());
+            System.out.println("ERROR " + e.getMessage());
+            e.printStackTrace(System.out);
             failureCallback.invoke(e.getMessage());
         }
     }

diff --git a/android/src/main/java/cl/json/social/ShareIntent.java b/android/src/main/java/cl/json/social/ShareIntent.java
@@ -56,8 +56,10 @@ public void open(ReadableMap options) throws ActivityNotFoundException {
             message = options.getString("message");
         }
 
-        String socialType = options.getString("social");
-
+        String socialType  = "";
+        if (ShareIntent.hasValidKey("social", options)) {
+            socialType = options.getString("social");
+        }
         if (socialType.equals("whatsapp")) {
             String whatsAppNumber = options.getString("whatsAppNumber");
             if (!whatsAppNumber.isEmpty()) {