Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): prevent implicit PendingIntent vulnerability #1046

Merged
merged 3 commits into from Jul 5, 2021
Merged

fix(android): prevent implicit PendingIntent vulnerability #1046

merged 3 commits into from Jul 5, 2021

Conversation

mussegam
Copy link
Contributor

Overview

Google Play rejects apps using this library because of an Implicit PendingIntent Vulnerability: https://support.google.com/faqs/answer/10437428

This PR should fix #1043

Test Plan

Verified that the sharing functionality works in my Android app with this fix

@MateusAndrade
Copy link
Collaborator

Nice! Did you manage to submit your app to Google Play with this fix?

@mussegam
Copy link
Contributor Author

Nice! Did you manage to submit your app to Google Play with this fix?

It's still in review, but at least they haven't complained about it yet. Will update as soon as I have more info :)

@MateusAndrade
Copy link
Collaborator

Nice! Did you manage to submit your app to Google Play with this fix?

It's still in review, but at least they haven't complained about it yet. Will update as soon as I have more info :)

Thanks for the feedback! We can proceed with this merge as soon as you got a response from Google. 🚀

@mussegam
Copy link
Contributor Author

mussegam commented Jul 5, 2021

Sorry it took so long, we had some unrelated issues with the release.
The version that includes this fix has been reviewed and is now available in production 💪

@MateusAndrade MateusAndrade merged commit 7a8dc5f into react-native-share:master Jul 5, 2021
MateusAndrade pushed a commit that referenced this pull request Jul 5, 2021
@semantic-release-bot
chore(release): 6.2.2 [skip ci]
82beebf 
## [6.2.2](v6.2.1...v6.2.2) (2021-07-05)

### Bug Fixes

* **android:** prevent implicit PendingIntent vulnerability ([#1046](#1046)) ([7a8dc5f](7a8dc5f))
@MateusAndrade
Copy link
Collaborator

🎉 This PR is included in version 6.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mikehardy mikehardy mentioned this pull request Oct 13, 2022
Closed
mobiledev7 added a commit to mobiledev7/react-native-share that referenced this pull request Dec 12, 2022
@mobiledev7
chore(release): 6.2.2 [skip ci]
7354324 
## [6.2.2](react-native-share/react-native-share@v6.2.1...v6.2.2) (2021-07-05)

### Bug Fixes

* **android:** prevent implicit PendingIntent vulnerability ([#1046](react-native-share/react-native-share#1046)) ([7a8dc5f](react-native-share/react-native-share@7a8dc5f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KencyK KencyK KencyK approved these changes

@MateusAndrade MateusAndrade MateusAndrade approved these changes

@jgcmarins jgcmarins Awaiting requested review from jgcmarins

@mikehardy mikehardy Awaiting requested review from mikehardy

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google play console rejected, PendingIntent issue
3 participants
@mussegam @MateusAndrade @KencyK