Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shareSingle telegram (iOS only) #1061

Merged
merged 3 commits into from
Jul 29, 2021

Conversation

akinncar
Copy link
Contributor

Overview

Add telegram shareSingle to iOS.
As I saw, Telegram share on iOS only allows sharing a simple text or simple text + url.

References:

I needed to add a new devDependency to can run commit linter when I changed the example app.

Test Plan

const shareToTelegram = async () => {
  const shareOptions = {
    message: 'Example Telegram',
    url: 'https://google.com',
    social: Share.Social.TELEGRAM,
  };

  try {
    const ShareResponse = await Share.shareSingle(shareOptions);
    setResult(JSON.stringify(ShareResponse, null, 2));
  } catch (error) {
    console.log('Error =>', error);
    setResult('error: '.concat(getErrorString(error)));
  }
};

Related

#1058

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good to me - except it should include an update to the docs entry as well?

https://github.com/react-native-share/react-native-share/blame/master/website/docs/share-single.mdx#L83

@akinncar
Copy link
Contributor Author

akinncar commented Jul 29, 2021

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 how did I miss that? There is nothing missing then, this looks like good work. Thanks!

@MateusAndrade
Copy link
Collaborator

Thanks @akinncar ! 😄

@MateusAndrade MateusAndrade merged commit 667171b into react-native-share:master Jul 29, 2021
MateusAndrade pushed a commit that referenced this pull request Jul 29, 2021
# [6.5.0](v6.4.0...v6.5.0) (2021-07-29)

### Features

* Add shareSingle telegram (iOS only) ([#1061](#1061)) ([667171b](667171b))
@MateusAndrade
Copy link
Collaborator

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@akinncar akinncar deleted the feat/telegram-ios branch July 29, 2021 21:47
mobiledev7 added a commit to mobiledev7/react-native-share that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants