-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shareSingle telegram (iOS only) #1061
Add shareSingle telegram (iOS only) #1061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all good to me - except it should include an update to the docs entry as well?
I already did here https://github.com/react-native-share/react-native-share/pull/1061/files#diff-2b156530ac8480a0ede43b606f2c052bea0d549547de15f086317ae5f1168fe4 Am I forgetting something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 how did I miss that? There is nothing missing then, this looks like good work. Thanks!
Thanks @akinncar ! 😄 |
# [6.5.0](v6.4.0...v6.5.0) (2021-07-29) ### Features * Add shareSingle telegram (iOS only) ([#1061](#1061)) ([667171b](667171b))
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [6.5.0](react-native-share/react-native-share@v6.4.0...v6.5.0) (2021-07-29) ### Features * Add shareSingle telegram (iOS only) ([#1061](react-native-share/react-native-share#1061)) ([667171b](react-native-share/react-native-share@667171b))
Overview
Add telegram shareSingle to iOS.
As I saw, Telegram share on iOS only allows sharing a simple text or simple text + url.
References:
I needed to add a new devDependency to can run commit linter when I changed the example app.
Test Plan
Related
#1058