fix(android): instagram direct share plain text #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimP4w
requested review from
jgcmarins,
MateusAndrade and
mikehardy
as code owners
MateusAndrade
approved these changes
Apr 14, 2023
|
Nice, thanks @TimP4w ! |
MateusAndrade
pushed a commit
that referenced
this pull request
Apr 14, 2023
## [8.2.2](v8.2.1...v8.2.2) (2023-04-14) ### Bug Fixes * **android:** instagram direct share plain text ([#1383](#1383)) ([f2aed9a](f2aed9a))
|
🎉 This PR is included in version 8.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
When using Share.open instead of Share.share, instagram is not in the options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hi there,
We are using your library at our company, however we had problems sharing direct messages on instagram with android.
The current behaviour is that nothing happens if a url is not provided, and when provided it says that the file type is not supported.
This patch tries to fix that by passing
text/*as type in the options.Test Plan
In the example app simply try to send an instagram direct message.
Cheers