AndroidX

[guillaume-tgl]

Ask your Question

Any plan to migrate to AndroidX now that it's a standard in react-native 0.60?

[mikehardy]

The library should certainly update, all libraries need to, but it's my understanding that https://github.com/mikehardy/jetifier will allow you to use the library regardless of your apps AndroidX conversion status or the libraries AndroidX conversion status

Since converting the library without jetifier working well with it implies orphaning current users of the library that cannot migrate, I'm much more interested in success reports (or bug reports!) about compatibility with jetifier + RN0.60 + AndroidX and jetifier -r + RN0.59 + this library as AndroidX then I am about converting immediately.

Once compatibility is confirmed in both directions, then it's largely inconsequential and could happen any time

[guillaume-tgl]

Thanks for the quick and detailed answer.
I confirm I was able to use this library with jetifier and RN0.60 so you're right, there's no need to hurry :)

[se-bastiaan]

Maybe it is good to keep this issue open for reference. Once/If (especially) reverse jetifier is compatible the update to AndroidX should be executed.

[mikehardy]

@se-bastiaan it is pinned currently, that puts it at the top of the page

[se-bastiaan]

That doesn't mean that the issue is done, right?

[jgcmarins]

References

• feat(android): BREAKING CHANGE upgrading to sdk 28 and androidx (#2068) react-native-camera/react-native-camera#2306

[MateusAndrade]

Anyone tested react-native-share with Android X/react-native 0.60 and got any problem?

[jgcmarins]

I guess that @Thomazella is working on it

[tcodes0]

Correct I'll post a status update in the next few days. :D

[sibelius]

npx jetifier

[kimihiro64]

I ran npx jetifier, it reported 1041 files forward jetified, but fails sync with:
ERROR: Unable to resolve dependency for ':react-native-share@debug/compileClasspath': Could not resolve com.android.support:appcompat-v7:28.0.0.

Not sure what to do from there... I can see the line that generates it in react-native-share's build.gradle, implementation "com.android.support:appcompat-v7:${safeExtGet('supportLibVersion', '28.0.0')}"... Was that supposed to get jetified to something else and it just didn't work?

EDIT: Not sure why but if you update to latest react-native-share, I was a bit behind, resync will fix this problem even though the same dependency is there :/

[oleksandr-dziuban]

@MateusAndrade Hello, I have tested react-native-share on a production project with react-native@0.60.3. iOS works fine in debug/release build, but Android fails in release build mode.
Please check this issue:
#549

[mikehardy]

@kimihiro64 yeah - you also need to change your supportLibVersion, and note that https://github.com/mikehardy/jetifier#module-maintainers item 2 here for module name overrides might be useful for people as long as AndroidX changes are being made

[MateusAndrade]

#550

[sibelius]

fixed on v2