Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instagram Stories on v2 #556

Closed
ithustle opened this issue Jul 26, 2019 · 15 comments · Fixed by #600
Closed

Instagram Stories on v2 #556

ithustle opened this issue Jul 26, 2019 · 15 comments · Fixed by #600
Labels
feature request instagram question stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@ithustle
Copy link

Ask your Question

Is instagram stories working on this version?

@jgcmarins
Copy link
Member

v2 was a great opportunity to release instagram stories
but we were focused on RN 0.60
if you're interested, I can help you with instructions to rollback instagram stories and release a v3
we just need to bring these changes: #505

@ithustle
Copy link
Author

@jgcmarins , yes I am. I would like to

@hbarylskyi
Copy link
Contributor

was any work done on this?

@MateusAndrade
Copy link
Collaborator

was any work done on this?

As i remember, we needed to remove some implementations related to stories on this version. But, we released some updates on the last weeks. @hbarylskyi you can give a try with that to help us know what is the actual state of this feature?

@hbarylskyi
Copy link
Contributor

@MateusAndrade I'm looking into the issue. I don't have much experience with rn libraries. How do you test the code in the library? copy it to a react-native project's node_modules manually and run functions from that react-native project?

@MateusAndrade
Copy link
Collaborator

MateusAndrade commented Sep 30, 2019

@MateusAndrade I'm looking into the issue. I don't have much experience with rn libraries. How do you test the code in the library? copy it to a react-native project's node_modules manually and run functions from that react-native project?

You can clone this repo, run a yarnat the root folder, and a yarn dev-sync. This command will copy everything from the root folder, to the node_modules folder at the example app.

https://github.com/react-native-community/react-native-share/blob/1d23acaeaba719b00f2af35119c8888742de8820/package.json#L57

@hbarylskyi
Copy link
Contributor

@MateusAndrade thank you!

@hbarylskyi
Copy link
Contributor

I managed to build and install in release mode after I disabled Dead Code Stripping in example target. Disabling it in RNShare didn't make any difference. So not sure if it's a solution since users would have to change their apps to make them build with this library. Any thoughts @MateusAndrade? Btw, here's the error I was getting:

Undefined symbols for architecture x86_64:
  "_RCTSetLogFunction", referenced from:
      -[exampleTests testRendersWelcomeScreen] in exampleTests.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@MateusAndrade
Copy link
Collaborator

@hbarylskyi you got this trying to run the example with react-native run-ios?? I will give a look at this tomorrow and warn you if i face this problem. :)

@hbarylskyi
Copy link
Contributor

@MateusAndrade I ran the example from Xcode.
First i did a git revert ec7ff153015da25ff7f861643c30bcef705a632d. Then I belive I got the error. Then disabled Dead Code Stripping. Should I push my changes to a fork so that you can try it?

@MateusAndrade
Copy link
Collaborator

@MateusAndrade I ran the example from Xcode.
First i did a git revert ec7ff153015da25ff7f861643c30bcef705a632d. Then I belive I got the error. Then disabled Dead Code Stripping. Should I push my changes to a fork so that you can try it?

Sure! This will help me a lot. 😄

@hbarylskyi
Copy link
Contributor

Ok. Will do later today.

@hbarylskyi
Copy link
Contributor

@MateusAndrade #600 👽

@stale
Copy link

stale bot commented Dec 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and i will leave this open.

@stale stale bot added the stale There has been a lack of activity on this issue and it may be closed soon. label Dec 4, 2019
@stale
Copy link

stale bot commented Dec 11, 2019

Closing this issue after a prolonged period of inactivity. Fell free to reopen this issue, if this still affecting you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request instagram question stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants