Support sharing of files from secondary storage i.e sd cards, on Android

[nirre7]

Overview

Currently the Android config does not support sharing of files from secondary storage (sd cards). Developers/users have used the base64 workaround for this, but I thought it would be a good idea to support it.
Also none of these would solve it:

  <external-files-path
    name="external_files"
    path="." />
  <external-cache-path
    name="external_cache"
    path="." />
<files-path
    name="files"
    path="." />

Test Plan

On an emulator or device, download an image to the sdcard or "external storage" and then share it.

[MateusAndrade]

Hi @nirre7 , thanks for that! Would you mind applying these changes to the example app? Also, this shouldn't be a problem setting this key <root-path name="rnshare_sdcard" path="." /> to rnshare_sdcard?

[nirre7]

rnshare_sdcard

Afaik the name attribute "rnshare_sdcard" could be whatever as long as it is not the same as other path configs. i.e the following wouldn't work:

    <cache-path name="test" path="." />
    <root-path name="test" path="." />

[nirre7]

@mikehardy @MateusAndrade
Also thank you for reviewing this so swiftly!

[nirre7]

@MateusAndrade

Would you mind applying these changes to the example app?

Not sure what you want me to do?

• There is nothing that needs to be done in an app that is using this lib, from a configuration perspective.
• The example app is using a base64 image (since it is "portable") for it's examples which gets handled by a different code path in the lib.

It might be me which is misunderstanding though 🤔

[MateusAndrade]

It might be me which is misunderstanding though 🤔

I think i misunderstand. HAHAHA Sorry for that.

[MateusAndrade]

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[nirre7]

It might be me which is misunderstanding though 🤔

I think i misunderstand. HAHAHA Sorry for that.

Ok, td bem 👍