New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (android): add support to Instagram Stories video sharing #933
feat (android): add support to Instagram Stories video sharing #933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kaioduarte! 🚀 🚀 🚀
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi, @MateusAndrade @kaioduarte I think you should not add provider logic to the generic class (ShareIntent.java). for that I should extend the class and add another social item and override the "open" method and add that logic like // ...
public class InstagramStoriesShare extends SingleShareIntent {
// ...
@Override
public void open(ReadableMap options) throws ActivityNotFoundException {
super.open(options);
// extra params here
if (ShareIntent.hasValidKey("method", options)) {
String method = options.getString("method");
switch (method) {
case "shareBackgroundVideo": {
// ...
}
case "shareBackgroundImage": {
// ...
}
case "shareStickerImage": {
// ...
}
case "shareBackgroundAndStickerImage": {
// ...
}
}
}
this.openIntentChooser(options);
}
} Gracias por compartir y aportar! Saludos! |
Nice suggestion, do you think we can go on with that @kaioduarte ? |
So we thought the same, @EstebanFuentealba! I'm implementing Thanks guys. |
@kaioduarte |
Do you mean the Android version? It's 11. |
Overview
Background video assets currently is only available for iOS, this PR aims to add support for Android as well.
Test Plan
Minimal example
Example
video_2020-12-21_18-19-08.mp4