Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make appId optional in Options type #964

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

geraintwhite
Copy link
Contributor

The appId option isn't mentioned in the docs but is marked as mandatory in the Options flow type which breaks flow type checking.

Copy link
Collaborator

@MateusAndrade MateusAndrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MateusAndrade MateusAndrade merged commit 80fc996 into react-native-share:master Feb 8, 2021
MateusAndrade pushed a commit that referenced this pull request Feb 8, 2021
## [5.1.1](v5.1.0...v5.1.1) (2021-02-08)

### Bug Fixes

* Make appId optional in Options type ([#964](#964)) ([80fc996](80fc996))
@MateusAndrade
Copy link
Collaborator

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mobiledev7 added a commit to mobiledev7/react-native-share that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants