fix: resolve promise on ios every time

[krystofcelba]

Overview

The Share.open promise doesn't resolve in some situations on iOS. For example when you cancel printing. It's well described in #865. This PR fixes that.

Fix #865 #857

Test Plan

Please check #865, there are steps for reproduce and it should work as expected with this fix.

[krystofcelba]

The condition here is unnecessary as the completion is checked here in JS code and in situations like canceled print it causes that the JS callback isn't called at all. So the bug is fixed just by removing the condition and calling the callback every time except there is activityError.

[MateusAndrade]

Nice!!! Thanks, @krystofcelba! 🚀 🚀 🚀

[MateusAndrade]

🎉 This PR is included in version 5.1.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[cristianoccazinsp]

This introduced the following bug: #972

I'm already testing a "fix", but it would be great to get @krystofcelba input.

[cristianoccazinsp]

Proposed update:

__weak UIActivityViewController* weakShareController = shareController;
    shareController.completionWithItemsHandler = ^(NSString *activityType, BOOL completed, __unused NSArray *returnedItems, NSError *activityError) {
        
        // always dismiss since this may be called from cancelled shares
        // but the share menu would remain open, and our callback would fire again on close
        [controller dismissViewControllerAnimated:true completion:nil];
        
        if (activityError) {
            failureCallback(activityError);
        } else {
            successCallback(@[@(completed), RCTNullIfNil(activityType)]);
        }
        
        // clear the completion handler to prevent cycles
        if(weakShareController){
            weakShareController.completionWithItemsHandler = nil;
        }
    };

This has the side effect that the share UI is always closed if the selected app was "cancelled". However, it doesn't seem possible to detect if the share UI was closed automatically by the system or not