Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"If the Share dialog is opened from a Modal, even Modal is getting dismissed when we close share dialog" - Issue Fix #988

Merged
merged 1 commit into from
Mar 26, 2021
Merged

"If the Share dialog is opened from a Modal, even Modal is getting dismissed when we close share dialog" - Issue Fix #988

merged 1 commit into from
Mar 26, 2021

Conversation

ShruthiRSalian
Copy link
Contributor

@ShruthiRSalian ShruthiRSalian commented Mar 25, 2021 •
edited by MateusAndrade

Overview

This PR fixes for #981 "If the Share dialog is opened from a Modal, even Modal is getting dismissed when we close share dialog".

Test Plan

@ShruthiRSalian
Copy link
Contributor Author

https://github.com/react-native-share/react-native-share/issues/981

@ShruthiRSalian
Copy link
Contributor Author

#981
Fix for the above issue

@mikehardy
Copy link
Collaborator

Hi there! "defect fix" does not tell me in active words what exactly this PR does? A title would be like "Share to NewNetwork with correct title" or similar

Also, if you actually put the exact text Fixes #981 just like that in the PR description github will automatically link the issue and this PR together for easy navigation

@ShruthiRSalian
Copy link
Contributor Author

Hi there! "defect fix" does not tell me in active words what exactly this PR does? A title would be like "Share to NewNetwork with correct title" or similar

Also, if you actually put the exact text Fixes #981 just like that in the PR description github will automatically link the issue and this PR together for easy navigation

Sorry, "defect fix" title. This PR is fix for #981 "If the Share dialog is opened from a Modal, even Modal is getting dismissed when we close share dialog".

@ShruthiRSalian ShruthiRSalian changed the title defect fix "If the Share dialog is opened from a Modal, even Modal is getting dismissed when we close share dialog" - Issue Fix Mar 25, 2021
@MateusAndrade
Copy link
Collaborator

MateusAndrade commented Mar 26, 2021 •
edited

Hey, @ShruthiRSalian thanks for your contribution! I changed the PR description and linked the issue! 🚀

@MateusAndrade MateusAndrade linked an issue Mar 26, 2021 that may be closed by this pull request
If the Share dialog is opened from a Modal, even Modal is getting dismissed when we close share dialog. #981
Closed
@MateusAndrade MateusAndrade merged commit bf300d0 into react-native-share:master Mar 26, 2021
MateusAndrade pushed a commit that referenced this pull request Mar 26, 2021
@semantic-release-bot
chore(release): 5.1.7 [skip ci]
fc10a0e 
## [5.1.7](v5.1.6...v5.1.7) (2021-03-26)

### Bug Fixes

* share dialog with modal ([#988](#988)) ([bf300d0](bf300d0))
@MateusAndrade
Copy link
Collaborator

🎉 This PR is included in version 5.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

mobiledev7 added a commit to mobiledev7/react-native-share that referenced this pull request Dec 12, 2022
@mobiledev7
chore(release): 5.1.7 [skip ci]
14e615c 
## [5.1.7](react-native-share/react-native-share@v5.1.6...v5.1.7) (2021-03-26)

### Bug Fixes

* share dialog with modal ([#988](react-native-share/react-native-share#988)) ([bf300d0](react-native-share/react-native-share@bf300d0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaysaini-sgvu ajaysaini-sgvu ajaysaini-sgvu approved these changes

@MateusAndrade MateusAndrade MateusAndrade approved these changes

@jgcmarins jgcmarins Awaiting requested review from jgcmarins

@mikehardy mikehardy Awaiting requested review from mikehardy

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If the Share dialog is opened from a Modal, even Modal is getting dismissed when we close share dialog.
5 participants
@ShruthiRSalian @mikehardy @MateusAndrade @ajaysaini-sgvu @ShruthiRS-91