Android dependencies #373
Merged
Android dependencies #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgcmarins
reviewed
Oct 1, 2018
jgcmarins
reviewed
Oct 1, 2018
sibelius
reviewed
Oct 1, 2018
mikehardy
force-pushed
the
android-dependencies
branch
from
5737325
to
de4770c
Compare
|
I just re-pushed with cleaner commit history, and current deps (android moves about as fast as react-native land it seems...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not super familiar with react-native-share yet, but I'm pretty familiar with android development and I thought maybe you guys could use a dependency refresh?
This quiets all the warnings you'd see with Android Studio current (3.2 now) by upgrading gradle, gradle wrapper scripts, repository definitions, and library versions.