Skip to content
This repository has been archived by the owner on Sep 13, 2020. It is now read-only.

Re-render Component right #335

Open
marcussombra opened this issue Apr 4, 2018 · 7 comments
Open

Re-render Component right #335

marcussombra opened this issue Apr 4, 2018 · 7 comments

Comments

@marcussombra
Copy link

every time I open and close the menu, my component (content on the right side, not the menu) re-render. Is this a bug?

@Michiel87
Copy link

Having the same problem. Any change in one of the components of the contentview triggers a re-render of the sidemenu and as such the entire contentview tree too. Is this intended behaviour?

@marcussombra
Copy link
Author

@Michiel87 I switched to DRYWER with react-native-flux.

@Michiel87
Copy link

@marcussombra thanks for the tip

@JediahDizon
Copy link

JediahDizon commented Jun 4, 2018

It would be great if someone can address this issue, as I still am experiencing it. Here is my setup:

<SideMenu	menu={<Menu />}>
	<Router>
		<Scene key="root" hideNavBar>
			<Scene key="auth">
				<Scene key="login" title="Login" />
			</Scene>
			<Scene key="main">
				<Scene key="projects" title="Projects" leftTitle="☰" onLeft={() => this.setState({ sidebar: { isOpen: !this.state.sidebar.isOpen }})} />
			</Scene>
		</Scene>
	</Router>
</SideMenu>

The library I'm using is the react-native-router-flux for the router. My componens are equipped with React Redux. Thanks in advanced!

side menu bug report

@AlexCatch
Copy link

It looks like the component doesn't re-render but it actually re-mounts as componentDidMount is called when opening and closing the side menu.

I'll check it out but not promising anything.

@wiloke1
Copy link

wiloke1 commented Dec 6, 2018

same problem

@charliewynn
Copy link

I get this as well, but it does not happen when using the swipe gesture to open the menu.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants