Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Allow createElement & unstable_createElement usage #1240

Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix(web): Allow createElement & unstable_createElement usage #1240

merged 2 commits into from
Jan 15, 2020

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented Jan 6, 2020

Hello πŸ‘‹

Summary

In react-native-web 0.12 (RC1 is available), createElement has been renamed to unstable_createElement. This PR introduces support for it without a breaking change.

Related issues:

Test Plan

What's required for testing (prerequisites)?

  • Bootstrapping an example project with react-native-web 0.12.0-rc.1 and react-native-svg.

Compatibility

OS Implemented
iOS ❌
Android ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@zoontek zoontek requested a review from msand January 6, 2020 10:11
@msand msand changed the base branch from master to develop January 15, 2020 00:21
@msand msand changed the title Allow createElement & unstable_createElement usage fix(web): Allow createElement & unstable_createElement usage Jan 15, 2020
@msand msand merged commit 7a23968 into software-mansion:develop Jan 15, 2020
msand pushed a commit that referenced this pull request Jan 18, 2020
# [11.0.0](v10.1.0...v11.0.0) (2020-01-18)

### Bug Fixes

* compatibility with reanimated color, fixes [#1241](#1241) ([4983766](4983766))
* **android:** NullPointerException when calling getBBox [#1215](#1215) ([3eb82a9](3eb82a9))
* **android:** support animating stroke color ([c5dd62f](c5dd62f))
* **android:** support setting path null ([2d34734](2d34734))
* **ios:** iOS 10.3 renders opaque background when drawRect is defined ([61bc9bd](61bc9bd)), closes [#1252](#1252)
* **web:** Allow createElement & unstable_createElement usage ([#1240](#1240)) ([7a23968](7a23968))

* fix(android)!: pivot point for RN transform array syntax ([db682f8](db682f8))

### BREAKING CHANGES

* Makes android specific transform origin adjustments
 unnecessary / broken. Renders exactly the same as web and ios instead.
@msand
Copy link
Collaborator

msand commented Jan 18, 2020

πŸŽ‰ This PR is included in version 11.0.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants