This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
fix: PagerPan not trigger onIndexChange when disable animation #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
approved these changes
Oct 30, 2018
FRizzonelli
added a commit
to FRizzonelli/react-native-tab-view
that referenced
this pull request
Dec 19, 2018
* docs: fix README renderScene code example (satya164#607) * feat: add RTL support in PagerAndroid * chore: release 1.2.0 * chore: use release-it for automated release * fix: fix PagerPan not triggering onIndexChange when animation is disabled (satya164#632) `PagerPan` doesn't trigger `props.onIndexChange` when `animationEnabled={false}`. without `Animated.parallel` and it's finished callback, `PagerPan` doesn't call `props.jumpTo` to make it all right. ### Test plan Use `PagerPan` and set `animationEnabled={false}`, should trigger `props.onIndexChange` correctly. * feat: delay rendering of unfocused tabs for better startup perf * chore: release 1.3.0 * docs: fix example in README * fix: remove unused code which causes a flow error (satya164#641) There was a flow error. This fixes it. ``` Error ---------------------------------------------------- ../../node_modules/react-native-tab-view/src/TabView.js:121:8 Property `delayRenderOfNonFocusedTabs` is missing in `State` [1]. ../../node_modules/react-native-tab-view/src/TabView.js:121:8 121| !this.state.delayRenderOfNonFocusedTabs || ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ References: ../../node_modules/react-native-tab-view/src/TabView.js:41:70 41| export default class TabView<T: *> extends React.Component<Props<T>, State> { ^^^^^ [1] ``` * docs: update README * chore: release 1.3.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PagerPandoesn't triggerprops.onIndexChangewhenanimationEnabled={false}. withoutAnimated.paralleland it's finished callback,PagerPandoesn't callprops.jumpToto make it all right.Test plan
Use
PagerPanand setanimationEnabled={false}, should triggerprops.onIndexChangecorrectly.