This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
fix: swipe between child and parent TabNavigator #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unfortunately, I had some issue. I have added PR with yarn add then it fails when app fetches file /react-native-tab-view/package.json |
|
I think you need to build first, which generates |
|
@satya164 any updates on this? I've been patching this library with these changes in order for nested tab swiping to work. |
|
I would love to have this merged :) |
|
I need this |
osdnk
reviewed
Jan 11, 2020
| }); | ||
| }; | ||
|
|
||
| // Cancel gesture if swiping back from initial tab or forward from last tab. |
There was a problem hiding this comment.
Suggested change
| // Cancel gesture if swiping back from initial tab or forward from last tab. | |
| // Cancel gesture if swiping back from the initial tab or forward from the last tab. |
osdnk
reviewed
Jan 11, 2020
| }; | ||
|
|
||
| // Cancel gesture if swiping back from initial tab or forward from last tab. | ||
| // Enables parent Pager to pick up the gesture, if one exists. |
There was a problem hiding this comment.
Suggested change
| // Enables parent Pager to pick up the gesture, if one exists. | |
| // Enables parent Pager to pick up the gesture if one exists. |
osdnk
approved these changes
Jan 11, 2020
osdnk
changed the title
gorhom
added a commit
to gorhom/react-native-tab-view
that referenced
this pull request
Apr 1, 2020
* master: feat: export TabBarIndicator (satya164#962) chore: fix workflows chore: release 2.13.0 chore: add workflow for publishing expo app chore: upgrade depenendecies fix: wrap tabview with gesture handler wrapper chore: update @types/react-native and remove TODO (satya164#956) feat: add InteractionHandle (satya164#905) chore: release 2.12.0 docs: add docs for ScrollPager (satya164#954) feat: add support for web in the example (satya164#948) feat: conditionally add scrollView on iOS instead of pager (satya164#952) feat: expose TabView and TabBar Props (satya164#941) fix: typos in comments fix: swipe between child and parent TabNavigator (satya164#881) chore: optimize images (satya164#946) docs: update Quick Start example with 0 index state (satya164#937) chore: upgrade expo to sdk 36 docs: use hooks for the example code docs: add info about usage with other libraries
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PanGestureHandlerto become the gesture handler.PanGestureHandlers to pass their refs up to the parent in order to use insimultaneousHandlersandwaitForprops.Motivation
Fixes #880
Test plan