Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

feat: export TabBarIndicator #962

Merged
merged 1 commit into from
Feb 5, 2020
Merged

feat: export TabBarIndicator #962

merged 1 commit into from
Feb 5, 2020

Conversation

donth77
Copy link
Contributor

@donth77 donth77 commented Feb 5, 2020

Motivation

Currently it’s possible to import TabBar and use the component as the tab bar in renderTabBar

import { TabBar } from 'react-native-tab-view';
 
...
 
<TabView
  renderTabBar={props => <TabBar {...props} />}
  ...
/>

Similarly it should also be possible to import TabBarIndicator so it can be used in renderIndicator.

import { TabBarIndicator } from 'react-native-tab-view';
 
...
 
<TabBar
  renderIndicator ={props => <TabBarIndicator {...props} />}
  ...
/>

I was attempting to modify the styles of the default indicator and realized that I couldn't import the component like this.

Test plan

For testing, ensure that the import statement doesn't introduce any errors.

Copy link
Owner

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@satya164 satya164 changed the title Export TabBarIndicator feat: export TabBarIndicator Feb 5, 2020
@satya164 satya164 merged commit 1f04e9f into satya164:master Feb 5, 2020
gorhom added a commit to gorhom/react-native-tab-view that referenced this pull request Apr 1, 2020
* master:
  feat: export TabBarIndicator (satya164#962)
  chore: fix workflows
  chore: release 2.13.0
  chore: add workflow for publishing expo app
  chore: upgrade depenendecies
  fix: wrap tabview with gesture handler wrapper
  chore: update @types/react-native and remove TODO (satya164#956)
  feat: add InteractionHandle (satya164#905)
  chore: release 2.12.0
  docs: add docs for ScrollPager (satya164#954)
  feat: add support for web in the example (satya164#948)
  feat: conditionally add scrollView on iOS instead of pager (satya164#952)
  feat: expose TabView and TabBar Props (satya164#941)
  fix: typos in comments
  fix: swipe between child and parent TabNavigator (satya164#881)
  chore: optimize images (satya164#946)
  docs: update Quick Start example with 0 index state (satya164#937)
  chore: upgrade expo to sdk 36
  docs: use hooks for the example code
  docs: add info about usage with other libraries
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants