Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for react native warning on componentWillReceiveProps #141

Conversation

alexnaiman
Copy link
Contributor

Summary

Fixed componentWillReceiveProps warning

Test Plan

What's required for testing (prerequisites)?

Empty project with the library installed

What are the steps to reproduce (after prerequisites)?

Run the app and check if the masking it is still working

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@iagormoraes
Copy link

can someone review this PR?

@jonassvalin
Copy link

Anyone? This is important to fix as componentWillReceiveProps will be removed in RN 0.17

@lundn
Copy link

lundn commented Mar 17, 2020

Can this be merged?

@walterholohan
Copy link

Are their any maintainers left on this repo?

@eltoncostadev
Copy link

Hey, shall we merge the pull request????

@warrenalphonso
Copy link

Merge this!!! Is there someone we can contact who has write access?

@SrBrahma
Copy link

SrBrahma commented Sep 4, 2020

@ivanzotov This is merged but not implemented in the current NPM package (2.0.0). Please, someone deploy this new version.

Edited again: I am using this PR with
npm i git+https://github.com/react-native-community/react-native-text-input-mask

@lukeDev19
Copy link

lukeDev19 commented Sep 16, 2020

Please merge this. or there is no one to do it?

@johnny-vikrant
Copy link

@ivanzotov Please release a new version with this PR. Thanks.

@diegormb06
Copy link

@ivanzotov Please release a new version with this fixes

@vikrantnegi
Copy link

@kelset Need help. The maintainer seems to be too busy. Thanks.

@jotahws
Copy link

jotahws commented Oct 19, 2020

Any updates on this?

@kelset
Copy link

kelset commented Oct 19, 2020

No updates on my side, I was not able to get in contact with the mantainer.

Maybe @brentvatne had any luck? Since I noticed the repo has been moved to its own org, I guess it means someone has write level admins over it.

@jhonattansolartearanda
Copy link

Any updates on this?

@acollazomayer
Copy link

Any updates?

@kelset
Copy link

kelset commented Jan 27, 2021

I've asked again in the RN core discord, and Brent said that basically @ivanzotov is the sole owner of this so I've tried asking directly to him on twitter 🤷‍♂️

@ivanzotov
Copy link
Collaborator

ivanzotov commented Jan 28, 2021

I've released 2.0.1 that includes this PR. It's probably the last release from my side, because I don't have time to maintain this project anymore. If anyone would like to maintain this please let me know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet