New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for react native warning on componentWillReceiveProps #141
Fix for react native warning on componentWillReceiveProps #141
Conversation
can someone review this PR? |
Anyone? This is important to fix as componentWillReceiveProps will be removed in RN 0.17 |
Can this be merged? |
Are their any maintainers left on this repo? |
Hey, shall we merge the pull request???? |
Merge this!!! Is there someone we can contact who has write access? |
@ivanzotov This is merged but not implemented in the current NPM package (2.0.0). Please, someone deploy this new version. Edited again: I am using this PR with |
Please merge this. or there is no one to do it? |
@ivanzotov Please release a new version with this PR. Thanks. |
@ivanzotov Please release a new version with this fixes |
@kelset Need help. The maintainer seems to be too busy. Thanks. |
Any updates on this? |
No updates on my side, I was not able to get in contact with the mantainer. Maybe @brentvatne had any luck? Since I noticed the repo has been moved to its own org, I guess it means someone has write level admins over it. |
Any updates on this? |
Any updates? |
I've asked again in the RN core discord, and Brent said that basically @ivanzotov is the sole owner of this so I've tried asking directly to him on twitter 🤷♂️ |
I've released 2.0.1 that includes this PR. It's probably the last release from my side, because I don't have time to maintain this project anymore. If anyone would like to maintain this please let me know. Thanks! |
Summary
Fixed componentWillReceiveProps warning
componentWillReceiveProps is deprecated and will be removed in the next major version of RN #133
I changed the lifecycle method from
componentWillReceiveProps
tocomponentDidUpdate
The JS part of the library
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
CHANGELOG.md
example/App.js
)