Added filterEnabled flag and don't enable filter if source is an hls playlist #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgzzjr
changed the title
nickgzzjr
changed the title
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
Added filterEnabled flag and don't enable filter if source is an hls playlist (rebased from commit b7a351c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make the filter functionality easier to use and prevent sacrificing performance (when you don't need filters). I went ahead and added a
filterEnabledflag which prevents/allows the filter to be set. Enabling filters from startup helps set filters on videos that have rotated orientation. Disabling filters prevent performance hits caused when using videoComposition.I've also added a check to make sure that filters are not applied when the source is not an HLS playlist.
Lastly, I updated the basic example to showcase filters.