Fix for isssue #1463 #1466
Closed
Fix for isssue #1463 #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Issue, directly accessing NativeModules.UIManager is no longer supported.
Propose to add import to UIManager directly from 'react-native' module on top and change the code from NativeModules.UIManager.RCTVideo.~~~ to UIManager.getViewManagerConfig('RCTVideo').~~~ as suggested from react-native's warning.
n1ru4l
suggested changes
Feb 15, 2019
There was a problem hiding this comment.
@uioporqwerty Thank you for your contribution! Just one small change, afterwards I am going to merge this 😊
| @@ -225,13 +225,13 @@ export default class Video extends Component { | |||
|
|
|||
| let nativeResizeMode; | |||
| if (resizeMode === VideoResizeMode.stretch) { | |||
| nativeResizeMode = NativeModules.UIManager.RCTVideo.Constants.ScaleToFill; | |||
| nativeResizeMode = UIManager.getViewManagerConfig('RCTVideo').Constants.ScaleToFill; | |||
There was a problem hiding this comment.
could you please move this a level higher?
E.g.
let nativeResizeMode;
const RCTVideoInstance = UIManager.getViewManagerConfig('RCTVideo')
if (resizeMode === VideoResizeMode.stretch) {
nativeResizeMode = RCTVideoInstance.Constants.ScaleToFill;
|
Is this already in npm? |
|
Yes included in 4.4.0 https://www.npmjs.com/package/react-native-video |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue, directly accessing NativeModules.UIManager is no longer supported.
Propose to add import to UIManager directly from 'react-native' module on top and change the code from NativeModules.UIManager.RCTVideo.~~~ to UIManager.getViewManagerConfig('RCTVideo').~~~ as suggested from react-native's warning.