Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Interactive Media Ads (IMA) SDK #1839

Closed
wants to merge 8 commits into from

Conversation

robbywh
Copy link
Contributor

@robbywh robbywh commented Dec 10, 2019

Hi everyone,

I have PR to play ad on video player with Interactive Media Ads (IMA) SDK.
Please Review my PR.

Best Regards,
Robby Widyahartono

@robbywh robbywh changed the title Interactive Media Ads (IMA) SDK Implement Interactive Media Ads (IMA) SDK Dec 10, 2019
@robbywh robbywh requested a review from CHaNGeTe January 28, 2020 07:48
@benoitdion
Copy link
Collaborator

Hi @robbywh, this overall looks great but unfortunately, we don't want to make IMA a required dependency for all users of react-native-video.

Eventually, I'd like to enable extensions like this via an extension mechanism. This would look something like:

<Video>
   <ImaPlugin someConfigValue="foo" />
</Video>

@robbywh
Copy link
Contributor Author

robbywh commented Feb 18, 2020

Hello @benoitdion, thank you for your response.

is there a development process that is being carried out?
If so, when will this feature be released?

@ayciceksahin
Copy link

Hi @benoitdion When can we reached it out ?
Or is there a development process that is being carried out? as @robbywh said

@sidferreira
Copy link

@robbywh @ayciceksahin I had a PR to work with it #1740

@jeffelector
Copy link

hi, what is the status of this?

@robbywh
Copy link
Contributor Author

robbywh commented Nov 13, 2020

@jeffelector i'm gonna close this PR, because react-native-video doesn't want to make IMA SDK become required dependency

@robbywh robbywh closed this Nov 13, 2020
@scott-thrillist
Copy link

@robbywh why don't you fork this project? Many of us want ad support

@sidferreira
Copy link

@scott-thrillist check #1740

@robbywh
Copy link
Contributor Author

robbywh commented Jul 30, 2021

@scott-thrillist I have forked this project, you can check in here: https://github.com/RobbyWH/react-native-video/tree/implement-ima-sdk

@liquidvisual
Copy link

@robbywh This is excellent, thanks! What version of react-native-video does it use? (sorry if that's a newb question)

@robbywh
Copy link
Contributor Author

robbywh commented Jul 30, 2021

Your welcome @liquidvisual , I still use version 5.1.0-alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants