-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Interactive Media Ads (IMA) SDK #1839
Conversation
change Platforms description for adTagUrl
Hi @robbywh, this overall looks great but unfortunately, we don't want to make IMA a required dependency for all users of react-native-video. Eventually, I'd like to enable extensions like this via an extension mechanism. This would look something like:
|
Hello @benoitdion, thank you for your response. is there a development process that is being carried out? |
Hi @benoitdion When can we reached it out ? |
@robbywh @ayciceksahin I had a PR to work with it #1740 |
hi, what is the status of this? |
@jeffelector i'm gonna close this PR, because react-native-video doesn't want to make IMA SDK become required dependency |
@robbywh why don't you fork this project? Many of us want ad support |
@scott-thrillist check #1740 |
@scott-thrillist I have forked this project, you can check in here: https://github.com/RobbyWH/react-native-video/tree/implement-ima-sdk |
@robbywh This is excellent, thanks! What version of react-native-video does it use? (sorry if that's a newb question) |
Your welcome @liquidvisual , I still use version 5.1.0-alpha1 |
Hi everyone,
I have PR to play ad on video player with Interactive Media Ads (IMA) SDK.
Please Review my PR.
Best Regards,
Robby Widyahartono