App Crash - UIViewControllerHierarchyInconsistency #167

ozgursoy · 2020-05-05T14:52:31Z

Bug

When i open the app, it crashes sometimes ( %20 crash rate )
There is no log on console, Flipper can't catch any error, Only Crashlytics catches the error.

Android is working very well.
There is no problem on version 3.3.0

react-native info output:

System:
    OS: macOS 10.15.3
    CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
    Memory: 162.63 MB / 8.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.11.1 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.14.5 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 11.3.1/11C505 - /usr/bin/xcodebuild
  Languages:
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1 
    react-native: 0.62.2 => 0.62.2 
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 4.0.0

The text was updated successfully, but these errors were encountered:

troZee · 2020-05-05T15:16:25Z

It is strange, that iOS fixes does not work for you.

You can checkout changelog here:
https://github.com/react-native-community/react-native-viewpager/releases/tag/v4.0.0

Could you provide reproducible example code ?

@krystiansliwa have you got any ideas ?

ozgursoy · 2020-05-05T15:23:54Z

Extra info:
We use redux-offline.
When i disable redux-online, works perfectly.
This is really strange because there is no problem on version 3.3.0

srfaytkn · 2020-05-05T15:30:02Z

+1

ahk093 · 2020-05-05T15:30:29Z

I have the same issue.

troZee · 2020-05-05T15:38:19Z

@srfaytkn @ahk093 Could you provide any reproducible example ?

ozgursoy · 2020-05-06T08:26:11Z

@troZee
I replaced childViewController.view = view;
to
[childViewController.view addSubview: view];
then issue is solved

I can't provide any reproducible example right now, i have to create a new project for this

troZee · 2020-05-06T13:39:08Z

@Farad4y
I checked 3 fixes, which has been included into 4.0 and I can't find any cause of above errors.
It is hard to say without reproducible example, where the problem is.

Now as workaround. You can fix it locally using patch-package.

I can't provide any reproducible example right now, i have to create a new project for this

No worries :D I am waiting for reproducible example

genglei01 · 2020-05-21T08:44:33Z

@troZee
I have the same issue and try @Farad4y's solution, the error seems to be fixed/(I try it many times)

I replaced childViewController.view = view;
to
[childViewController.view addSubview: view];

Inexpressible · 2020-05-21T22:09:14Z

This error happens for us with screens that have multiple carousels. The suggested patch fixed the issue.

ozgursoy · 2020-05-24T05:00:45Z

@genglei01 @Inexpressible Could you provide example project? My project that crashes is very big, so i can't simplified it

tekmin · 2020-06-01T03:33:33Z

We have the same issue, but not reproducible from our project too. I will try on @Farad4y solutions first.

jpamarohorta · 2020-06-05T16:11:24Z

I had the same issue and @Farad4y patch fixed it. Here is the patch created using patch-package:

diff --git a/node_modules/@react-native-community/viewpager/ios/ReactNativePageView.m b/node_modules/@react-native-community/viewpager/ios/ReactNativePageView.m
index cbb3b36..d7e8893 100644
--- a/node_modules/@react-native-community/viewpager/ios/ReactNativePageView.m
+++ b/node_modules/@react-native-community/viewpager/ios/ReactNativePageView.m
@@ -379,7 +379,7 @@ - (void)setReactViewControllers:(NSInteger)index
 
 - (UIViewController *)createChildViewController:(UIView *)view {
     UIViewController *childViewController = [[UIViewController alloc] init];
-    childViewController.view = view;
+    [childViewController.view addSubview: view];
     return childViewController;
 }

genglei01 · 2020-06-10T02:20:16Z

Is there any release schedule for this bug?

troZee · 2020-06-10T05:11:44Z

Is there any release schedule for this bug?

I will merge and release it, once someone provides me an example to test it.

jpamarohorta · 2020-06-16T17:56:54Z

In my case the crash occurred 10% of the times this component was mounted (stats from Firebase), so it's difficult to track and make an example that always crashes.

stami · 2020-06-30T07:55:55Z

There may be a race condition causing this crash.

UIViewControllerHierarchyInconsistency
A view can only be associated with at most one view controller at a time!

In ReactNativePageView.m the createChildViewController is called with the same array of UIViews (self.reactSubviews) from renderChildrenViewControllers and addPages.

The @Farad4y 's patch fixes the issue because addSubview removes the previous superview if needed before adding it to the new superview.

RodrigoSosa95 · 2020-07-15T22:44:20Z

+1 on this issue, even on version 4.1.0 happens to me when called viewPager.current.setPage.

troZee · 2020-07-16T12:16:20Z

It has been resolved here #189 in 4.1.0 version.

eladgel · 2020-07-18T20:53:30Z

Has this been really fixed? Making sure before I upgrade my library. @RodrigoSosa95 ?

chj-damon · 2020-07-30T02:10:41Z

I'm facing the same problem. I'll try to upgrade the version and see if it's fixed.

enigmablue · 2020-08-01T04:01:06Z

Also faced the same problem. omg i hope this fixes.

Have upgraded to "@react-native-community/viewpager": "^4.1.3", and will monitor

troZee · 2020-08-03T12:18:03Z

I reopening this issue, because bug still exist

enigmablue · 2020-08-03T13:02:53Z

Yes i'm getting the same error. But this time, it's not (randomly) killing the app completely, just consistently throwing an error. My current unglamorous workaround to fix the race condition is to set a timeout on the setPage as i think its having a race condition on the list in the state that is referred in the viewpager:

const listener = (shares ,changes) => {
...
 changes.insertions.forEach((index) => {
let updatedShares = getUpdatedShares()

     setTimeout(()=>{
       setDisplayList(updatedShares);
       }, 100) //needed to set timeout here because of some other issue on pausing video

       setTimeout(()=>{
         viewPager.current && viewPager.current.setPage(0)
       }, 200) //viewpager race condition problem with setpage
}
...
}

My viewpager code

<ViewPager
        style={{flex: 1}}
        initialPage={0}
        ref={viewPager}
        orientation="vertical"
        onPageScroll={onPageScroll}
        onPageSelected={onPageSelected}
        onPageScrollStateChanged={onPageScrollStateChanged}
        >
        {displayList && displayList.map((share,index) =>
          renderSlide(share, index)
        )}
        </ViewPager>

joebochill · 2020-11-30T17:27:06Z

I narrowed down the problem in my case to version 4.1.0.

4.0.1: works as expected
4.1.0: throws the ViewController error above and the app crashes.

bonlemuel · 2020-12-03T13:25:04Z

@joebochill

I confirm that 4.0.1 is also working on my end.

Thank you! Saved me a lot of time figuring out a fix.

cjhines · 2021-07-30T07:01:40Z

This seems to have to reappeared (5.4.0 + iOS).

Exception thrown while executing UI block: A view can only be associated with at most one view controller at a time! View <RCTView: 0x7fe85544df90; reactTag: 7413; frame = (0 0; 0 0); layer = <CALayer: 0x6000002f6180>> is associated with <UIViewController: 0x7fe8550becb0>. Clear this association before associating this view with <UIViewController: 0x7fe854f78b50>.

__44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke
    RCTUIManager.m:1193
__44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke.493
__RCTExecuteOnMainQueue_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_callback_4CF
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
-[UIApplication _run]
UIApplicationMain
main
start
0x0

sezginriggs · 2021-07-30T11:35:07Z

In addition to above reply, I also have the same error with IOS 13.7

troZee · 2021-08-09T13:44:06Z

I am getting the same error as @bonlemuel. Mine does not seem to be related to dialogs though. I get the error when the ViewPager is rendered conditionally after some asynchronous data is loaded.

Simplified example:
    return conditionSatisfied ? (
        <View>
            <SafeAreaView>
                <ViewPager
                    ref={viewPager}
                    initialPage={0}
                >
                    <View style={{height: 500, width: 300, backgroundColor: 'orange'}}/>
                    <View style={{height: 500, width: 300, backgroundColor: 'red'}}/>
                    <View style={{height: 500, width: 300, backgroundColor: 'blue'}}/>
                    <View style={{height: 500, width: 300, backgroundColor: 'green'}}/>
                </ViewPager>
            </SafeAreaView>
        </View>
    ) : (
        <LoadingComponent />
    ) 
The other component doesn't seem to matter...I can return null and still get the same error.

Downgrading to 3.x makes the issue go away, but I was using 4.x before I upgraded my RN version to 0.63.

I was trying to reproduce using below code:

import React, { useMemo } from 'react';
import { StyleSheet, View, SafeAreaView, Animated, Text } from 'react-native';

import PagerView from 'react-native-pager-view';

import { LikeCount } from './component/LikeCount';
import { NavigationPanel } from './component/NavigationPanel';
import { useNavigationPanel } from './hook/useNavigationPanel';

const AnimatedPagerView = Animated.createAnimatedComponent(PagerView);

export function BasicPagerViewExample() {
  const { ref, ...navigationPanel } = useNavigationPanel();

  const [isLoading, setLoading] = React.useState(true);

  const pages = useMemo(
    () =>
      navigationPanel.pages.map((page, index) => (
        <View key={page.key} style={page.style} collapsable={false}>
          <LikeCount />
          <Text testID={`pageNumber${index}`}>{`page number ${index}`}</Text>
        </View>
      )),
    [navigationPanel.pages]
  );

  React.useEffect(() => {
    const timer = setTimeout(() => {
      setLoading(false);
    }, 1000);
    return () => {
      clearTimeout(timer);
    };
  }, []);

  return isLoading ? (
    <View />
  ) : (
    <SafeAreaView style={styles.container}>
      <AnimatedPagerView
        //@ts-ignore
        testID="pager-view"
        ref={ref}
        style={styles.PagerView}
        initialPage={2}
        layoutDirection="ltr"
        overdrag={navigationPanel.overdragEnabled}
        scrollEnabled={navigationPanel.scrollEnabled}
        onPageScroll={navigationPanel.onPageScroll}
        onPageSelected={navigationPanel.onPageSelected}
        onPageScrollStateChanged={navigationPanel.onPageScrollStateChanged}
        pageMargin={10}
        // Lib does not support dynamically orientation change
        orientation="horizontal"
        // Lib does not support dynamically transitionStyle change
        transitionStyle="scroll"
        showPageIndicator={navigationPanel.dotsEnabled}
      >
        {pages}
      </AnimatedPagerView>
      <NavigationPanel {...navigationPanel} />
    </SafeAreaView>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: 'white',
  },
  image: {
    width: 300,
    height: 200,
    padding: 20,
  },
  PagerView: {
    flex: 1,
  },
});

and I was not able to do that

wildseansy · 2021-08-10T22:19:25Z

From my tests, this issue is in v5.3.4 too (released on the same day). v5.3.3 is the safest version in my investigation

This seems to have to reappeared (5.4.0 + iOS).

Exception thrown while executing UI block: A view can only be associated with at most one view controller at a time! View <RCTView: 0x7fe85544df90; reactTag: 7413; frame = (0 0; 0 0); layer = <CALayer: 0x6000002f6180>> is associated with <UIViewController: 0x7fe8550becb0>. Clear this association before associating this view with <UIViewController: 0x7fe854f78b50>.

__44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke
    RCTUIManager.m:1193
__44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke.493
__RCTExecuteOnMainQueue_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_callback_4CF
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
-[UIApplication _run]
UIApplicationMain
main
start
0x0

theambidextrous · 2021-08-16T12:31:27Z

this issue still persists in 5.4.0. Am using it as a dependency of @react-navigation/material-top-tabs

Here is the error:

Exception thrown while executing UI block: A view can only be associated with at most one view controller at a time! View <RCTView: 0x7fe9ef208a00; reactTag: 313; frame = (0 0; 0 0); clipsToBounds = YES; layer = <CALayer: 0x600001061760>> is associated with <UIViewController: 0x7fe9ed45ed30>. Clear this association before associating this view with <UIViewController: 0x7fe9ed656d70>.

__44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke
RCTUIManager.m:1193
__44-[RCTUIManager flushUIBlocksWithCompletion:]_block_invoke.493
__RCTExecuteOnMainQueue_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_callback_4CF
CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
-[UIApplication _run]
UIApplicationMain
main
start

msimon · 2021-08-16T12:36:56Z

Downgrading to 4.2.4 worked for me on IOS.

Something else that I notice, is that this bug seems to happen when the app is cold. I never had it randomly, only when I opened the app for the first time after a while.

theambidextrous · 2021-08-16T12:44:45Z

Downgrading to 4.2.4 worked for me on IOS.

Something else that I notice, is that this bug seems to happen when the app is cold. I never had it randomly, only when I opened the app for the first time after a while.

Seems so. For me, the apps runs well on first start, but the error shows when i restart the RN Bundler or when i close and reopen the app on the simulator.

let me try downgrade to 4.2.4

alimek · 2021-08-17T10:22:31Z

I found workaround for that issue, delay rendering ViewPager by 50ms, its enough to fix issue for me and almost not visible to end user.

bonlemuel · 2021-08-17T11:23:25Z

Downgrading works for me as well.

theambidextrous · 2021-08-17T11:26:11Z

Yes, i can confirm the same. either version 4.2.4 or 5.3.3 ... they both work, so i went with 5.3.3

rborn · 2021-08-19T09:29:13Z

Worked for me with a combination between delaying the render with 50ms and downgrade to 5.3.0 😿

Bardiamist · 2021-08-23T09:33:49Z

I have this error now. Appeared after update React native to 0.65.0 (coincidence?). Problem related with some view from PagerView.

Screenshot

upd: looks revert from 5.4.0 to 5.3.3 helped

troZee · 2021-08-23T12:31:25Z

Can anyone test this code ? #432

Instructions:

open node_modules/react-native-pager-view/ios/ReactNativePageView.m file
copy/paste this https://raw.githubusercontent.com/callstack/react-native-pager-view/0da6df0765d7c23ec66c637983fb26316ce2fdec/ios/ReactNativePageView.m into above file
yarn ios and check if error still occurs

Bardiamist · 2021-08-23T12:52:04Z

Can anyone test this code ? #432

Instructions:

open node_modules/react-native-pager-view/ios/ReactNativePageView.m file

copy/paste this https://raw.githubusercontent.com/callstack/react-native-pager-view/0da6df0765d7c23ec66c637983fb26316ce2fdec/ios/ReactNativePageView.m into above file

yarn ios and check if error still occurs

I tested. Looks no crash (it not 100% reproducable for me so tested 6 times without errors). But I can't change page by gesture with this code.

troZee · 2021-08-23T13:02:59Z

Can anyone test this code ? #432
Instructions:

open node_modules/react-native-pager-view/ios/ReactNativePageView.m file

copy/paste this https://raw.githubusercontent.com/callstack/react-native-pager-view/0da6df0765d7c23ec66c637983fb26316ce2fdec/ios/ReactNativePageView.m into above file

yarn ios and check if error still occurs

I tested. Looks no crash (it not 100% reproducible for me so tested 6 times without errors). But I can't change page by gesture with this code.

Thank you for the replay. I am on it.

troZee · 2021-08-23T13:09:35Z

@Bardiamist
I have pushed a new commit. Could you retest it ?

Bardiamist · 2021-08-23T13:15:17Z

@Bardiamist
I have pushed a new commit. Could you retest it ?

LGTM. Tested 5 times without crash. Gesture was fixed.

troZee · 2021-08-23T13:17:47Z

@Bardiamist
I have pushed a new commit. Could you retest it ?

LGTM. Tested 5 times without crash. Gesture was fixed.

Thank you for cooperation. Before the merge, I will wait for the other developers.

troZee · 2021-08-23T19:08:40Z

This issue has been fixed here: https://github.com/callstack/react-native-pager-view/releases/tag/v5.4.1

troZee added the Resolution: Needs Repro This issue could be improved with a demo to reproduce the issue. label May 5, 2020

troZee added the ios label May 5, 2020

troZee changed the title ~~IOS App Crash - UIViewControllerHierarchyInconsistency~~ App Crash - UIViewControllerHierarchyInconsistency May 5, 2020

ozgursoy mentioned this issue May 21, 2020

Fix UIViewControllerHierarchyInconsistency #175

Merged

troZee closed this as completed Jul 16, 2020

troZee reopened this Aug 3, 2020

troZee removed the Resolution: Needs Repro This issue could be improved with a demo to reproduce the issue. label Aug 3, 2020

joebochill mentioned this issue Nov 30, 2020

Update packages to ~latest etn-ccis/blui-react-native-workflows#35

Merged

MateWW mentioned this issue Dec 8, 2020

fix: app crashing while setPage in componentDidMount on IOS #261

Merged

1 task

troZee closed this as completed Jul 22, 2021

sezginriggs mentioned this issue Jul 30, 2021

App crash - RTCView error #415

Closed

troZee reopened this Aug 9, 2021

rborn mentioned this issue Aug 19, 2021

A view can only be associated with at most one view controller at a time with material-top-tabs #429

Closed

10 tasks

troZee mentioned this issue Aug 23, 2021

fix(ios): UIViewControllerHierarchyInconsistency error #432

Merged

troZee closed this as completed in #432 Aug 23, 2021

ghasemikasra39 mentioned this issue Sep 13, 2021

Exception thrown: A view can only be associated with at most one view controller at a time #439

Closed

App Crash - UIViewControllerHierarchyInconsistency #167

App Crash - UIViewControllerHierarchyInconsistency #167

Comments

ozgursoy commented May 5, 2020

Bug

troZee commented May 5, 2020

ozgursoy commented May 5, 2020

srfaytkn commented May 5, 2020

ahk093 commented May 5, 2020

troZee commented May 5, 2020

ozgursoy commented May 6, 2020

troZee commented May 6, 2020 • edited

genglei01 commented May 21, 2020

Inexpressible commented May 21, 2020

ozgursoy commented May 24, 2020

tekmin commented Jun 1, 2020 • edited

jpamarohorta commented Jun 5, 2020

genglei01 commented Jun 10, 2020

troZee commented Jun 10, 2020

jpamarohorta commented Jun 16, 2020

stami commented Jun 30, 2020 • edited

RodrigoSosa95 commented Jul 15, 2020

troZee commented Jul 16, 2020

eladgel commented Jul 18, 2020

chj-damon commented Jul 30, 2020

enigmablue commented Aug 1, 2020 • edited

troZee commented Aug 3, 2020

enigmablue commented Aug 3, 2020 • edited

joebochill commented Nov 30, 2020

bonlemuel commented Dec 3, 2020

cjhines commented Jul 30, 2021

sezginriggs commented Jul 30, 2021

troZee commented Aug 9, 2021

wildseansy commented Aug 10, 2021 • edited

theambidextrous commented Aug 16, 2021

msimon commented Aug 16, 2021

theambidextrous commented Aug 16, 2021

alimek commented Aug 17, 2021

bonlemuel commented Aug 17, 2021

theambidextrous commented Aug 17, 2021

rborn commented Aug 19, 2021

Bardiamist commented Aug 23, 2021 • edited

troZee commented Aug 23, 2021

Bardiamist commented Aug 23, 2021

troZee commented Aug 23, 2021

troZee commented Aug 23, 2021

Bardiamist commented Aug 23, 2021

troZee commented Aug 23, 2021

troZee commented Aug 23, 2021

troZee commented May 6, 2020 •

edited

tekmin commented Jun 1, 2020 •

edited

stami commented Jun 30, 2020 •

edited

enigmablue commented Aug 1, 2020 •

edited

enigmablue commented Aug 3, 2020 •

edited

wildseansy commented Aug 10, 2021 •

edited

Bardiamist commented Aug 23, 2021 •

edited