-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Android project to use AndroidX support library #22
Conversation
Thank you very much! I'll take a look today or tomorrow. |
@aarongrider I tried this in a new generated project |
I'm wondering if we should wait to merge this until RN 60 is released with AndroidX support. As far as I understand, AndroidX projects are incompatible with legacy support projects when compiled from source. This library shouldn't be a huge issue for consumers since you distribute compiled aar's, but it's something we should keep in mind. |
I'd now use it now, as RN 0.59 is still on support libs plus most of the libs did not move to |
You should provide a version now even if react-native 0.60 is not yet released... |
0.60 is out. Source: Announcing React Native 0.60 |
@@ -5,7 +5,7 @@ buildscript { | |||
minSdkVersion = 16 | |||
compileSdkVersion = 28 | |||
targetSdkVersion = 27 | |||
supportLibVersion = "28.0.0" | |||
supportLibVersion = "1.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this property name is misleading. Maybe it should be like appcompatVersion
?
We want to wait on this till 2.0 is released (so 2.0 is also compatible before RN 0.60.x). Then we can add these changes for 3.0. For now, if you want to use this library in RN 0.60.x just follow the jetifier instructions. |
@aarongrider @ferrannp @troZee any updates on this one? 2.0.0 is out and RN is already 0.61 Jetifier is doing it's job, however I think it's already time to migrate |
@ferrannp can you please merge this and push a new release ? |
@aarongrider hey I am closing this in favour of #103. Sorry for that! But we also need the example working if we update to Android X so we want to speed things up. We'll make a new release when that is merged. @bhandarijiwan till then just use jetifier or run |
Use AndroidX in place of legacy Android support libraries. This is required for any Android projects that use AndroidX for support libraries.
See: https://developer.android.com/jetpack/androidx/migrate
Specifically react-native-gesture-handler currently has a 4 PRs to migrate to AndroidX being blocked by this down stream dependency for our tests that require this dependency.