Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow _target links to be opened up in the same way as UIWebView. #270

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Allow _target links to be opened up in the same way as UIWebView. #270

merged 3 commits into from
Feb 1, 2019

Conversation

benjosantony
Copy link
Contributor

Fixes #139 .

@jerolimov jerolimov mentioned this pull request Jan 25, 2019
Closed
Cordazar
Cordazar approved these changes Jan 25, 2019
View reviewed changes
Copy link

@Cordazar Cordazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves my problem with a facebook login.

@Titozzz Titozzz added Type: feature request New feature or request Maintainer: need testing Code looks good, can someone help us and test this ? labels Jan 25, 2019
@benjosantony
Copy link
Contributor Author

@Titozzz Anyway I could help assist in the review ?

@Titozzz
Copy link
Collaborator

Titozzz commented Jan 30, 2019

Code looks good, but I did not have time to test yet. Hopefuly soon

@jamonholmgren
Copy link
Member

I'll test this one @Titozzz.

@jamonholmgren jamonholmgren self-assigned this Jan 30, 2019
@jamonholmgren jamonholmgren added Maintainer: ready to publish This PR has been reviewed and is ready to be published and removed Maintainer: need testing Code looks good, can someone help us and test this ? labels Jan 31, 2019
jamonholmgren
jamonholmgren approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@Titozzz Titozzz merged commit 6643a8e into react-native-webview:master Feb 1, 2019
Titozzz pushed a commit that referenced this pull request Feb 1, 2019
@semantic-release-bot
chore(release): 4.1.0 [skip ci]
79afbd6 
# [4.1.0](v4.0.0...v4.1.0) (2019-02-01)

### Features

* **WKwebview:** Allow _target links to be opened up in the same way as UIWebView. ([#270](#270)) ([6643a8e](6643a8e)), closes [#139](#139)
@Titozzz
Copy link
Collaborator

Titozzz commented Feb 1, 2019

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

phuongwd pushed a commit to phuongwd/react-native-webview that referenced this pull request Apr 29, 2020
@benjosantony @Titozzz
feat(WKwebview): Allow _target links to be opened up in the same way …
d086fc8 
…as UIWebView. (react-native-webview#270)

Fixes react-native-webview#139
phuongwd pushed a commit to phuongwd/react-native-webview that referenced this pull request Apr 29, 2020
@semantic-release-bot
chore(release): 4.1.0 [skip ci]
4589f90 
# [4.1.0](react-native-webview/react-native-webview@v4.0.0...v4.1.0) (2019-02-01)

### Features

* **WKwebview:** Allow _target links to be opened up in the same way as UIWebView. ([react-native-webview#270](react-native-webview#270)) ([6643a8e](react-native-webview@6643a8e)), closes [react-native-webview#139](react-native-webview#139)
noproblem23 added a commit to noproblem23/react-native-webview that referenced this pull request Apr 18, 2023
@noproblem23
chore(release): 4.1.0 [skip ci]
4400651 
# [4.1.0](react-native-webview/react-native-webview@v4.0.0...v4.1.0) (2019-02-01)

### Features

* **WKwebview:** Allow _target links to be opened up in the same way as UIWebView. ([#270](react-native-webview/react-native-webview#270)) ([6643a8e](react-native-webview/react-native-webview@6643a8e)), closes [#139](react-native-webview/react-native-webview#139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cordazar Cordazar Cordazar approved these changes

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees

@jamonholmgren jamonholmgren

Labels
Maintainer: ready to publish This PR has been reviewed and is ready to be published Type: feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjosantony @Titozzz @jamonholmgren @Cordazar