Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.56.x (latest: 0.56.0) #15

Closed
grabbou opened this issue Apr 3, 2018 · 11 comments
Closed

0.56.x (latest: 0.56.0) #15

grabbou opened this issue Apr 3, 2018 · 11 comments
Labels
release status Information about an upcoming or ongoing release stable Stable version

Comments

@grabbou
Copy link
Member

grabbou commented Apr 3, 2018

0.56.0

@grabbou grabbou added release status Information about an upcoming or ongoing release rc Release candidate labels Apr 3, 2018
@react-native-community react-native-community locked and limited conversation to collaborators Apr 3, 2018
@grabbou
Copy link
Member Author

grabbou commented Apr 16, 2018

An update: I have temporary issues with my laptop and setting up a new dev environment today. I will try to cut new release today if no master errors happen in the meantime. Otherwise, it will happen tomorrow.

Would be great if people that are waiting or somewhat blocked by this could "+1" this message so that I have a better overview of the consumption rate.

@grabbou
Copy link
Member Author

grabbou commented Apr 17, 2018

Unfortunately, the master is still broken with some issues related to Babel (who knows what happens when we fix them).

Pinged the core team for the first time after a while to see where we are.

@hramos
Copy link
Collaborator

hramos commented May 24, 2018

We're working hard to resolve the remaining test failures in master. Here's a summary of where we're at.

test_android is failing

Our Android tests break often, for various reasons. It has a large surface area, and changes related to BUCK, Android, or JavaScript can all introduce a failure. Once these tests go red, it's easy to lose track of new failures and getting back to green can take a while. This is where we're at.

After fixing some BUCK issues and reverting to Android SDK 23, the latest blocker is a failure to build the JavaScript bundle necessary to run our unit tests on Android. This should be resolved once jest-haste-map is updated to support SHA-1 generation for haste modules in node_modules (facebook/react-native#18995 (review)).

test_javascript is failing

The latest failure can be attributed to some failing snapshot tests, following the release of jest@23.0.0-charlie.2. Undefined props are no longer printed out to snapshots. This should be resolved by updating our snapshots, but Facebook is currently using jest@23.0.0-charlie.1 in the internal monorepo that contains React Native. Once that codebase moves to jest@23.0.0, we should be able to unblock ourselves here.

There's still one more failing test that needs to be addressed before we can get back to green:

Summary of all failing tests
 FAIL  Libraries/Animated/src/__tests__/Animated-test.js
  ● Animated tests › Animated › send toValue when an underdamped spring stops

    Ran 100000 timers, and there are still more! Assuming we've hit an infinite recursion and bailing out...

      140 |       anim.addListener(listener);
      141 |       Animated.spring(anim, {toValue: 15}).start();
    > 142 |       jest.runAllTimers();
          |            ^
      143 |       const lastValue =
      144 |         listener.mock.calls[listener.mock.calls.length - 2][0].value;
      145 |       expect(lastValue).not.toBe(15);

      at FakeTimers.runAllTimers (node_modules/jest-util/build/fake_timers.js:194:13)
      at Object.<anonymous> (Libraries/Animated/src/__tests__/Animated-test.js:142:12)

Objective-C e2e tests are failing

These are failing for the same reason as test_android: we're unable to build the JavaScript bundle.

If you're interested in seeing 0.56.x getting released, please consider how you may be able to help in resolving the issues outlined above.

@hramos
Copy link
Collaborator

hramos commented Jun 3, 2018

test_javascript is now fixed. Once test_android and the Objective-C e2e tests are green, we should be good to go with 0.56. Contributions are welcome.

@hramos
Copy link
Collaborator

hramos commented Jun 11, 2018

All tests green and ready to go.

@hramos
Copy link
Collaborator

hramos commented Jun 11, 2018

0.56.0-rc.0 is now public.

@grabbou grabbou changed the title 0.56.x (latest: n/a) 0.56.x (latest: 0.56.0-rc.0) Jun 21, 2018
@grabbou
Copy link
Member Author

grabbou commented Jun 21, 2018

Latest version as of now is: 0.56.0-rc.2.

@grabbou
Copy link
Member Author

grabbou commented Jun 21, 2018

Status: CI tests pending
Date: 21/06/2018
Next update: 21/06/2018
Expected status: RC published

@hramos hramos changed the title 0.56.x (latest: 0.56.0-rc.0) 0.56.x (latest: 0.56.0-rc.2) Jun 26, 2018
@grabbou grabbou changed the title 0.56.x (latest: 0.56.0-rc.2) 0.56.x (latest: 0.56.0-rc.3) Jun 27, 2018
@grabbou
Copy link
Member Author

grabbou commented Jun 27, 2018

Status: CI tests pending
Date: 21/06/2018
Next update: 21/06/2018
Expected status: RC published (0.56.0-rc.4)

@grabbou grabbou changed the title 0.56.x (latest: 0.56.0-rc.3) 0.56.x (latest: 0.56.0-rc.4) Jun 27, 2018
@grabbou
Copy link
Member Author

grabbou commented Jun 27, 2018

Status: RC published (0.56.0-rc.4)
Date: 21/06/2018

@grabbou grabbou changed the title 0.56.x (latest: 0.56.0-rc.4) 0.56.x (latest: 0.56.0) Jul 4, 2018
@grabbou grabbou added stable Stable version and removed rc Release candidate labels Jul 4, 2018
@grabbou
Copy link
Member Author

grabbou commented Jul 4, 2018

Status: Stable published (0.56.0)
Date: 4/07/2018

@grabbou grabbou closed this as completed Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release status Information about an upcoming or ongoing release stable Stable version
Projects
None yet
Development

No branches or pull requests

2 participants