Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Highlight big breaking changes? #6

Closed
Minishlink opened this issue Mar 7, 2018 · 1 comment
Closed

Highlight big breaking changes? #6

Minishlink opened this issue Mar 7, 2018 · 1 comment

Comments

@Minishlink
Copy link

Hey :)

Thanks for taking the time to write such detailed changelogs, it helps a lot! Here's a small feedback on latest changelog (0.54):

It would be great to highlight the big breaking changes, for example:

  • [BREAKING] Delete RCTBatchedBridge
@turnrye
Copy link
Member

turnrye commented Mar 10, 2018

Hey @Minishlink, thanks for the feedback! The "Removed" section represents only removed features, not just instances of removed code. This is consistent with Keep a Changelog 1.0.0. Everything present in that section is a breaking change. I'll make sure to add a detail going forward in the headings to help clarify, since I don't think the verbiage is universal ("removed" vs "breaking"). Thanks again – this sort of feedback is exactly what we need. Please reopen if there are additional thoughts.

@turnrye turnrye closed this as completed Mar 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants