Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint & prettier pre git hooks #75

Closed
vinnyA3 opened this issue Jul 26, 2019 · 1 comment
Closed

Add eslint & prettier pre git hooks #75

vinnyA3 opened this issue Jul 26, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@vinnyA3
Copy link
Collaborator

vinnyA3 commented Jul 26, 2019 •
edited

Feature Request

I think it would be helpful to have a precommit / post hooks to run eslint and/or prettier

Why it is needed

This way, code that doesn't conform to repo style standards won't push. Also helps with automating linting & prettifying tasks.

Possible implementation

Use husky package to create pre hooks
@vinnyA3 vinnyA3 changed the title Add eslint & prettier precommit hooks Add eslint & prettier pre git hooks Jul 28, 2019
@vinnyA3 vinnyA3 mentioned this issue Jul 28, 2019
Merged
2 tasks
@lucasbento lucasbento added the enhancement New feature or request label Jul 29, 2019
@vinnyA3
Copy link
Collaborator Author

vinnyA3 commented Aug 9, 2019

This issue can be closed 🎊

@kelset kelset closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucasbento @vinnyA3 @kelset