Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #97

Closed
pvinis opened this issue Sep 5, 2019 · 11 comments · Fixed by #372
Closed

Dark mode #97

pvinis opened this issue Sep 5, 2019 · 11 comments · Fixed by #372
Labels
enhancement New feature or request

Comments

@pvinis
Copy link
Member

pvinis commented Sep 5, 2019

We should add a dark mode, so we don't get blind.

@kelset kelset added the enhancement New feature or request label Sep 5, 2019
@lucasbento
Copy link
Member

I'm spending some time on this, what I got so far:

Upgrade-Helper with Dark Mode

Upgrade-Helper with Dark Mode and the from dropdown version opened

I would really appreciate feedback on the colors, I'm basically just trying stuff until it looks good, still have quite some stuff to do though.

/cc @pvinis @kelset @KevinHu2014 @vinnyA3 @iamrestrepo

@lucasbento
Copy link
Member

As a reference, this is how a GitHub PR looks like when using GitHub-Dark:

PR on GitHub with GitHub-Dark

@Johan-dutoit
Copy link

Johan-dutoit commented Sep 17, 2019

I'd only suggest to improve accessibility (ps. I might have gotten the green color wrong, also need to check the red).

Screenshot 2019-09-17 at 13 13 47

@lucasbento
Copy link
Member

lucasbento commented Sep 17, 2019

@Johan-dutoit: thanks for the tip!

What tool are you using to check that?

The green color is #6ba978 btw, don't know if that will change much though.

@Johan-dutoit
Copy link

Johan-dutoit commented Sep 17, 2019

I just used https://webaim.org/resources/contrastchecker/

i.e. https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=6BA978

@vinnyA3
Copy link
Collaborator

vinnyA3 commented Sep 17, 2019

@Johan-dutoit useful tool! thank you for sharing 😄

@vinnyA3
Copy link
Collaborator

vinnyA3 commented Sep 17, 2019

@lucasbento Looks awesome! My eyes thank you lol.
Kind of sort of tangential, but where are you planning on putting the toggle? I was thinking perhaps it would be nice to put it in the settings dropdown.

@lucasbento
Copy link
Member

@vinnyA3: yeah, I want to put on the settings but still need to look into it.

@KevinHu2014
Copy link
Contributor

@lucasbento Wow! It looks Awesome 👍

@SaeedZhiany
Copy link

is there any progress on this?

@pvinis
Copy link
Member Author

pvinis commented Nov 12, 2022

not yet. I might spend some time soon. Until then, I recommend https://darkreader.org/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants