Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Do not pass exception instance to rejecter #111

Merged
merged 1 commit into from
Apr 10, 2021
Merged

[iOS] Do not pass exception instance to rejecter #111

merged 1 commit into from
Apr 10, 2021

Conversation

MAKARD
Copy link
Contributor

@MAKARD MAKARD commented Apr 5, 2021

Do not know why exactly it can't get access to localized description, but from JS perspective exception instance not needed.

This fix will make these errors much more specific AND this error will be catchable on JS side:

#103
#59
#56

…ion]: unrecognized selector sent to instance
@MAKARD MAKARD changed the title Do not pass exception instance to rejecter [iOS] Do not pass exception instance to rejecter Apr 6, 2021
@safaiyeh
Copy link
Member

This is an awesome PR! Appreciate it

@safaiyeh safaiyeh merged commit 597f32e into react-native-cookies:master Apr 10, 2021
safaiyeh pushed a commit that referenced this pull request Apr 10, 2021
## [6.0.7](v6.0.6...v6.0.7) (2021-04-10)

### Bug Fixes

* **iOS:** Do not pass exception instance to rejecter ([#111](#111)) ([597f32e](597f32e))
@safaiyeh
Copy link
Member

🎉 This PR is included in version 6.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants