Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale props not working with IOS countdown mode #429

Closed
ingerable opened this issue Apr 5, 2021 · 3 comments
Closed

Locale props not working with IOS countdown mode #429

ingerable opened this issue Apr 5, 2021 · 3 comments

Comments

@ingerable
Copy link

ingerable commented Apr 5, 2021

Locale props not working with IOS countdown mode

Summary

When I am using the mode Props with "countdown" value the strings are not translated even though I filled
the locale props with "fr-FR" value. Locale props is working well for "date" mode but not for "countdown" mode.

Reproducible sample code

<DateTimePicker
                mode={"countdown"}
                locale={"fr-FR"}
                style={{ height: "80%" }}
                value={new Date(0, 0, 0, 0, 1, 5)}
              />

Steps to reproduce

  1. Create a DateTimePicker
  2. Set props mode to "countdown"
  3. Set props locale to "fr-FR"

Describe what you expected to happen:

  1. "hours" and "min" strings should be translated to French

Environment info

"datetimepicker": "3.4.3"
"react-native": "0.63.3"

IOS 14

@MatBdry
Copy link

MatBdry commented Apr 6, 2021

Hi,

I got the same issue on my Emulator, where the default language was... English. I changed it to French and now it's working ;)

J'espère que ça t'a aidé !

@ingerable
Copy link
Author

It may work if you want you want to use the native language of the device but what if you want to support multiple language ? With a dynamic locale ?
Merci quand même !

@vonovak vonovak mentioned this issue Dec 11, 2021
5 tasks
@vonovak
Copy link
Member

vonovak commented Dec 11, 2021

closed by #540 (v5 release)

@vonovak vonovak closed this as completed Dec 11, 2021
@react-native-datetimepicker react-native-datetimepicker locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants