Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pixel 3a from devicesWithNotch.ts #1221

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

soonoo
Copy link
Contributor

@soonoo soonoo commented Apr 18, 2021

Description

Pixel 3a does not have a notch.

Compatibility

OS Implemented
iOS
Android
Windows

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (privateTypes.ts, types.ts)
  • I added a sample use of the API (example/App.js)

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed not! Thanks for the image link to verify

@mikehardy mikehardy merged commit ee959d9 into react-native-device-info:master Apr 18, 2021
rndi-bot pushed a commit that referenced this pull request Apr 18, 2021
## [8.1.2](v8.1.1...v8.1.2) (2021-04-18)

### Bug Fixes

* **notch:** remove `pixel 3a` from devicesWithNotch.ts ([#1221](#1221)) ([ee959d9](ee959d9))
@rndi-bot
Copy link
Collaborator

🎉 This PR is included in version 8.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

WictorWilnd added a commit to WictorWilnd/react-native-device-info that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants