fix(hasNotch): add Redmi Note 8 Pro to hasNotch list #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Redmi Note 8 Pro
yevhenlv
requested review from
GantMan,
Johan-dutoit,
machour and
mikehardy
as code owners
yevhenlv
changed the title
yevhenlv
changed the title
mikehardy
reviewed
Aug 4, 2021
mikehardy
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
This was close - but you actually did more work than necessary! The changelog is updated automatically via semantic-release when a PR is merged. I proposed a change + committed same to remove that so it's just the notch list update - if it passes CI I'll merge it and it will auto-release
Thanks!
mikehardy
changed the title
rndi-bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
## [8.1.6](v8.1.5...v8.1.6) (2021-08-05) ### Bug Fixes * **hasNotch:** add Redmi Note 8 Pro to hasNotch list ([#1276](#1276)) ([06e2b6c](06e2b6c))
|
🎉 This PR is included in version 8.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
WictorWilnd
added a commit
to WictorWilnd/react-native-device-info
that referenced
this pull request
Feb 27, 2023
## [8.1.6](react-native-device-info/react-native-device-info@v8.1.5...v8.1.6) (2021-08-05) ### Bug Fixes * **hasNotch:** add Redmi Note 8 Pro to hasNotch list ([#1276](react-native-device-info/react-native-device-info#1276)) ([3bc596c](react-native-device-info/react-native-device-info@3bc596c))
wdavis122
added a commit
to wdavis122/react-native-device-info
that referenced
this pull request
Jun 6, 2024
## [8.1.6](react-native-device-info/react-native-device-info@v8.1.5...v8.1.6) (2021-08-05) ### Bug Fixes * **hasNotch:** add Redmi Note 8 Pro to hasNotch list ([#1276](react-native-device-info/react-native-device-info#1276)) ([06e2b6c](react-native-device-info/react-native-device-info@06e2b6c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1275
Add Redmi Note 8 Pro to the list of devices with notch
Compatibility
Checklist
README.mdprivateTypes.ts,types.ts)example/App.js)