-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows): react-native-device-info don't work with apps in RNW v0.64 #1279
Conversation
Fixing ReactNativeWindowsProps to get from the directory of the solution (SolutionDir).
Fixing ReactNativeWindowsProps to get from the directory of the solution (SolutionDir).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks for taking this on! I don't regularly use react-native-windows so I really, really appreciate the help keeping it running
If it passes CI I'll merge it in
Auto-release in 3...2...1 - thanks again! |
## [8.1.7](v8.1.6...v8.1.7) (2021-08-05) ### Bug Fixes * **windows:** react-native-device-info don't work with apps in RNW v0.64 ([#1279](#1279)) ([d1a5c4e](d1a5c4e))
🎉 This PR is included in version 8.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [8.1.7](react-native-device-info/react-native-device-info@v8.1.6...v8.1.7) (2021-08-05) ### Bug Fixes * **windows:** react-native-device-info don't work with apps in RNW v0.64 ([#1279](react-native-device-info/react-native-device-info#1279)) ([48d3ac2](react-native-device-info/react-native-device-info@48d3ac2))
## [8.1.7](react-native-device-info/react-native-device-info@v8.1.6...v8.1.7) (2021-08-05) ### Bug Fixes * **windows:** react-native-device-info don't work with apps in RNW v0.64 ([#1279](react-native-device-info/react-native-device-info#1279)) ([d1a5c4e](react-native-device-info/react-native-device-info@d1a5c4e))
Description
Fixes #1278
Replace macro of msbuild in project file.
Compatibility