Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add missing hasGms hasHms flow types #1436

Merged
merged 1 commit into from Jul 11, 2022
Merged

fix(types): add missing hasGms hasHms flow types #1436

merged 1 commit into from Jul 11, 2022

Conversation

passerbyloo
Copy link
Contributor

Description

Fixes #

Add hasGms,hasHms missing flow type

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌
Windows ✅❌

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I added the documentation in README.md
  • I updated the typings files (privateTypes.ts, types.ts)
  • I added a sample use of the API (example/App.js)

mikehardy
mikehardy approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good as far as it goes, I'm honestly surprised anyone is still using flow types :-), but if you're willing to submit PRs, I can certainly merge them. Thanks!

@mikehardy mikehardy added the pending-merge looks good, waiting on CI or similar label Jul 11, 2022
@mikehardy mikehardy changed the title Add hasGms,hasHms missing flow type fix(types): add missing hasGms hasHms flow types Jul 11, 2022
@mikehardy
Copy link
Collaborator

flow types for getDeviceId / getDeviceIdSync probably out of sync since v10 as well, for what it's worth

@mikehardy mikehardy merged commit f51fb98 into react-native-device-info:master Jul 11, 2022
rndi-bot pushed a commit that referenced this pull request Jul 11, 2022
@semantic-release-bot
chore(release): 10.0.1 [skip ci]
ae563e7 
## [10.0.1](v10.0.0...v10.0.1) (2022-07-11)

### Bug Fixes

* **types:** add missing hasGms hasHms flow types ([#1436](#1436)) ([f51fb98](f51fb98))
@rndi-bot
Copy link
Collaborator

🎉 This PR is included in version 10.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@passerbyloo
Copy link
Contributor Author

some old projects

@mikehardy mikehardy removed the pending-merge looks good, waiting on CI or similar label Feb 15, 2023
WictorWilnd added a commit to WictorWilnd/react-native-device-info that referenced this pull request Feb 27, 2023
@WictorWilnd @semantic-release-bot
chore(release): 10.0.1 [skip ci]
86ad517 
## [10.0.1](react-native-device-info/react-native-device-info@v10.0.0...v10.0.1) (2022-07-11)

### Bug Fixes

* **types:** add missing hasGms hasHms flow types ([#1436](react-native-device-info/react-native-device-info#1436)) ([3b990ce](react-native-device-info/react-native-device-info@3b990ce))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@machour machour Awaiting requested review from machour machour is a code owner

@GantMan GantMan Awaiting requested review from GantMan GantMan is a code owner

@Johan-dutoit Johan-dutoit Awaiting requested review from Johan-dutoit Johan-dutoit is a code owner

@schie schie Awaiting requested review from schie schie is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@passerbyloo @mikehardy @rndi-bot