Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would love to see a Two-Marker Slider for Setting a Range #15

Closed
quadsurf opened this issue Sep 13, 2016 · 19 comments
Closed

Would love to see a Two-Marker Slider for Setting a Range #15

quadsurf opened this issue Sep 13, 2016 · 19 comments
Labels
component: Slider Issue related to Slider Component ✨ Enhancement

Comments

@quadsurf
Copy link

No description provided.

@dabit3
Copy link
Collaborator

dabit3 commented Sep 13, 2016

@quadsurf This sounds like a good idea. Can you shoot over a link to an example of what you had in mind, maybe implemented somewhere else? Thanks

@bucketclan
Copy link

I think he is referring to a bidirectional related slider.
Similar to the one on Tinder or something like the one shown in the link(http://www.tutorialspark.com/jqueryUI/jQuery_UI_Slider_Bidirectional_Related_Slider.php)
I would love to have this too.

@Monte9
Copy link
Collaborator

Monte9 commented Dec 23, 2016

@quadsurf Here are some sliders that I found.

  1. https://github.com/jeanregisser/react-native-slider - I like that it's customizable & API looks pretty robust.
  2. https://github.com/JackDanielsAndCode/react-native-multi-slider - Has implementation of multi-selection slider
  3. https://github.com/franfran/react-native-snap-slider - Love the functionality that this provides

I think adding a custom slider API (like 1) + multi-selection (like 2) + snap functionality (like 3) would be good addition to the elements.

@dabit3 thoughts?

@dabit3
Copy link
Collaborator

dabit3 commented Dec 24, 2016

@Monte9 I like the idea of having the customizable api of 1 and the multi selection of 2, and the snap functionality looks cool as well.

  1. We can possibly add one of those existing projects as a dependency to get the component working out of the box.

  2. or maybe you can even fork #1 and implement the two slider feature into a pr or something and we can still add as a dependency

  3. or maybe we can copy the existing component and add out tweaks as a new component to RN Elements?

I'm cool with any of these ideas, or anything along those lines really.

@Monte9
Copy link
Collaborator

Monte9 commented Feb 12, 2017

Update: Slider has been added to the latest release of RNE. Check out the documentation here.

We went with Option 1. I'll leave this issue open as it would be cool to add on Option 2 & Option 3 to the existing Slider component.

If anyone has bandwidth and would like to submit a PR to enhance it, I am open to merging it.

@Monte9 Monte9 added this to the 0.11.0 milestone Feb 23, 2017
@Monte9
Copy link
Collaborator

Monte9 commented Mar 13, 2017

In an effort to streamline all RNE issues such that it is easier to get to solutions faster/ submit a new issue we have decided to close any enhancement/roadmap features as "issues".

Feel free to use this issue to talk about this feature and ping @binoy14 or me (@Monte9) if you feel like you can submit a PR for this. Thanks in advance.

Also you can track the status of this feature and all other roadmap features here.

@deadcoder0904
Copy link

Would love to see 2 sliders as well :)

I see this is a fork of jeanregisser/react-native-slider#142 so this PR does just that.

What do ya'll think?

@Monte9 Monte9 reopened this Jun 5, 2019
@flyingcircle flyingcircle added this to the Release 3.0 milestone Jun 28, 2020
@flyingcircle flyingcircle added the component: Slider Issue related to Slider Component label Jul 8, 2020
@flyingcircle flyingcircle modified the milestones: Release 2.1, 2.2 Release Aug 2, 2020
@flyingcircle flyingcircle removed this from the 2.2 Release milestone Aug 9, 2020
@mt81
Copy link

mt81 commented Jan 18, 2021

@flyingcircle I am interested in developing this,

@flyingcircle
Copy link
Collaborator

@mt81 go for it.

@HariAcidReign
Copy link

@flyingcircle Apologies for the duplicate ticket, but the idea is still worth implementing right? I've read all the closed PRs and issues on this thread, and I think I can work on implementing the Slider ideas 2 and 3. Is it alright if I start working on adding them to the library and then to the app?

@mhimanshu712
Copy link

I would like to work on it as well. @flyingcircle

@hetanthakkar
Copy link
Contributor

Working on this

@HariAcidReign
Copy link

Hey, I have already started working on this one. I'm actually planning to add it to RNEU after approval. Do check out other issues.

@hetanthakkar
Copy link
Contributor

hetanthakkar commented Apr 25, 2021

@HariAcidReign What is your approach!? I also started ! Its been 5 days so I thought you started doing some other issues!?

@HariAcidReign
Copy link

I had described it in the above issue in RNEU. They haven't given the go-ahead yet, but I had started to implement it anyway. So hopefully by this weekend, I should be done with half of my proposed issues. And the rest will be done (implementation+tests) by next weekend. 👍🏻

@hetanthakkar
Copy link
Contributor

@HariAcidReign Sure no problem go ahed. Goodluck!

@hetanthakkar
Copy link
Contributor

hetanthakkar commented Apr 25, 2021

@HariAcidReign This component will probably require tests! If you are not writing tests I can do that if you can let me know few implementation details!? Or you have also started writing tests!?

@HariAcidReign
Copy link

Haven't started testing yet. If I get any hiccups, I'll let you know for sure 🎉

@arpitBhalla
Copy link
Member

Closing this in favor of this discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Slider Issue related to Slider Component ✨ Enhancement
Projects
None yet
Development

No branches or pull requests