-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would love to see a Two-Marker Slider for Setting a Range #15
Comments
@quadsurf This sounds like a good idea. Can you shoot over a link to an example of what you had in mind, maybe implemented somewhere else? Thanks |
I think he is referring to a bidirectional related slider. |
@quadsurf Here are some sliders that I found.
I think adding a custom slider API (like 1) + multi-selection (like 2) + snap functionality (like 3) would be good addition to the elements. @dabit3 thoughts? |
@Monte9 I like the idea of having the customizable api of 1 and the multi selection of 2, and the snap functionality looks cool as well.
I'm cool with any of these ideas, or anything along those lines really. |
Update: Slider has been added to the latest release of RNE. Check out the documentation here. We went with Option 1. I'll leave this issue open as it would be cool to add on Option 2 & Option 3 to the existing Slider component. If anyone has bandwidth and would like to submit a PR to enhance it, I am open to merging it. |
In an effort to streamline all RNE issues such that it is easier to get to solutions faster/ submit a new issue we have decided to close any enhancement/roadmap features as "issues". Feel free to use this issue to talk about this feature and ping @binoy14 or me (@Monte9) if you feel like you can submit a PR for this. Thanks in advance. Also you can track the status of this feature and all other roadmap features here. |
Would love to see 2 sliders as well :) I see this is a fork of jeanregisser/react-native-slider#142 so this PR does just that. What do ya'll think? |
@flyingcircle I am interested in developing this, |
@mt81 go for it. |
@flyingcircle Apologies for the duplicate ticket, but the idea is still worth implementing right? I've read all the closed PRs and issues on this thread, and I think I can work on implementing the Slider ideas 2 and 3. Is it alright if I start working on adding them to the library and then to the app? |
I would like to work on it as well. @flyingcircle |
Working on this |
Hey, I have already started working on this one. I'm actually planning to add it to RNEU after approval. Do check out other issues. |
@HariAcidReign What is your approach!? I also started ! Its been 5 days so I thought you started doing some other issues!? |
I had described it in the above issue in RNEU. They haven't given the go-ahead yet, but I had started to implement it anyway. So hopefully by this weekend, I should be done with half of my proposed issues. And the rest will be done (implementation+tests) by next weekend. 👍🏻 |
@HariAcidReign Sure no problem go ahed. Goodluck! |
@HariAcidReign This component will probably require tests! If you are not writing tests I can do that if you can let me know few implementation details!? Or you have also started writing tests!? |
Haven't started testing yet. If I get any hiccups, I'll let you know for sure 🎉 |
Closing this in favor of this discussion |
No description provided.
The text was updated successfully, but these errors were encountered: