Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Flow typings for v12 #1288

Closed
short-dsb opened this issue May 23, 2024 · 2 comments · Fixed by #1289
Closed

Restore Flow typings for v12 #1288

short-dsb opened this issue May 23, 2024 · 2 comments · Fixed by #1289
Labels
released

Comments

@short-dsb
Copy link

flow typings have been removed. Let me know if you need them

Believe it or not, we’re still using Flow. Is it a problem to restore these?

Thanks for all your work on this project!

Environment

  • react-native 0.74.0
  • @react-native-google-signin/google-signin 12.0.0
@vonovak vonovak mentioned this issue May 24, 2024
Merged
@vonovak
Copy link
Member

vonovak commented May 24, 2024

Hello and thanks for reporting,
I added them back. If they are off, please open a PR. Given you have an app with flow, you can test them better than me.

Thank you 🙂

@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 12.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add back flow types react-native-google-signin/google-signin
2 participants
@vonovak @short-dsb