Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss sign-in event on user Cancel #31

Closed
ethul opened this issue Feb 1, 2016 · 5 comments
Closed

Dismiss sign-in event on user Cancel #31

ethul opened this issue Feb 1, 2016 · 5 comments

Comments

@ethul
Copy link

ethul commented Feb 1, 2016

I have a use-case where I would like to track if the user taps the Cancel button in the sign-in dialog.

In order to do this, would it be possible to send an event when dismissViewController is invoked?

It would be helpful to be able to distinguish if dismissViewController was called due to the user pressing Cancel or due to a successful sign in.

I am open to other ideas or options, but I thought having this would be useful.

@devfd
Copy link
Contributor

devfd commented Feb 2, 2016

Ok I will look into it. I have to check if the login result is already available in the dismissViewController method.

otherwise it means you have to use some kind of timeout upon receiving the dismiss event to determine if the user pressed the Cancel button.

@ethul
Copy link
Author

ethul commented Feb 2, 2016

Thanks for checking in to it!

@devfd
Copy link
Contributor

devfd commented Feb 7, 2016

the signIn method now returns an error with code -5 on user cancel. please see the readme and let me know if it fits your purpose

@devfd devfd closed this as completed Feb 7, 2016
@ethul
Copy link
Author

ethul commented Feb 7, 2016

Great! Thanks. This will work for my use-case.

@eranbes
Copy link

eranbes commented Aug 3, 2016

Hi there (can you reopen please)

As you can see it does not work on Android. No -5 here. Can you please recheck?
Alternatively, what's the proper way to check cancellation on Android?

pasted image at 2016_08_03 16_53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants